mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 59099: Enabled authorization for v1 API call UPDATE_MAINTENANCE_SCHEDULE.
Date Mon, 12 Jun 2017 15:53:45 GMT


> On June 10, 2017, 5:45 p.m., Greg Mann wrote:
> > src/master/http.cpp
> > Line 4098 (original), 4139-4141 (patched)
> > <https://reviews.apache.org/r/59099/diff/7/?file=1743762#file1743762line4139>
> >
> >     You could do without the lambda here, right?
> >     
> >     ```
> >     .then(defer(
> >         master->self(),
> >         &Master::Http::___updateMaintenanceSchedule,
> >         schedule,
> >         lambda::_1));
> >     ```
> 
> Alexander Rojas wrote:
>     I could but I find the more unreadable. I will update accordingly anyway.
> 
> Alexander Rojas wrote:
>     come to tink about it, I don't think that works, because you are not operating in
master. If it were `&Master::____updateMaintenanceSchedule` it would work.
> 
> Alexander Rojas wrote:
>     So, now I am cetain that the lambda is needed, to use your proposed construct, if
one uses a `Process<T>` in deffer, one needs a member of `T` as the callled paramter
(`T::*method(...)`). But `__updateMaintenanceStatus()` is not a method of `Master` but a member
of `Master::Http`.

Yeah, very unfortunate but also entirely true.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59099/#review177533
-----------------------------------------------------------


On June 12, 2017, 1:31 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59099/
> -----------------------------------------------------------
> 
> (Updated June 12, 2017, 1:31 p.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-7415
>     https://issues.apache.org/jira/browse/MESOS-7415
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enables the use of authorization for the 'UPDATE_MAINTENANCE_SCHEDULE'
> v1 API call, using the ACL 'UpdateMaintenanceSchedule' and the action
> of the same name as the API call.
> 
> It also updates the 'ApiTests' to take into account the authorization
> case.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 
>   src/master/master.hpp e8ddddf273256b14cde1cac390163f948241757f 
>   src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54 
> 
> 
> Diff: https://reviews.apache.org/r/59099/diff/8/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message