mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 59988: Added a new protobuf message `MapMessage` for protobuf tests.
Date Mon, 12 Jun 2017 15:41:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59988/#review177626
-----------------------------------------------------------



It seems that  majority of this patch is generated code. Is the `.proto` change the only real
code change? If so, should we write some c++ test code to use the map based fields and json
parsing of map?

Also, explaining which files are generated in summary will help reviewers to know what changes
we can safekly skip reading?

- Zhitao Li


On June 12, 2017, 2:06 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59988/
> -----------------------------------------------------------
> 
> (Updated June 12, 2017, 2:06 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a new protobuf message `MapMessage` for protobuf tests.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/protobuf_tests.pb.h 2e4ffe17a07ce2360ec618e936ae4557e9dc8e62 
>   3rdparty/stout/tests/protobuf_tests.pb.cc ad6eff779d1cc0e7d037ea77565533c3ebb0b2d6

>   3rdparty/stout/tests/protobuf_tests.proto d16726aa8060aea2b830040b20dbdd467c801483

> 
> 
> Diff: https://reviews.apache.org/r/59988/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message