mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 59101: Enabled authorization when accesing maintenance status in v0 and v1 API.
Date Mon, 12 Jun 2017 13:00:04 GMT


> On June 10, 2017, 7:31 p.m., Greg Mann wrote:
> > src/master/http.cpp
> > Lines 4649-4651 (patched)
> > <https://reviews.apache.org/r/59101/diff/5/?file=1743768#file1743768line4649>
> >
> >     Can do without the lambda here, right?

As mentioned in the previos review, the lambda cannot go away, since your suggestion requires
`_getMaintenanceStatus()` to be a method of `Master`.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59101/#review177549
-----------------------------------------------------------


On June 7, 2017, 3:07 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59101/
> -----------------------------------------------------------
> 
> (Updated June 7, 2017, 3:07 p.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-7415
>     https://issues.apache.org/jira/browse/MESOS-7415
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enables the use of authorization for the `GET_MAINTENANCE_STATUS` v1
> API call, as well as to the `maintenance/status` endpoint, using the
> ACL `GetMaintenanceStatus` and the action of the same name as the API
> call.
> 
> It also updates the ApiTests to take into account the authorization
> case.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 
>   src/master/master.hpp e8ddddf273256b14cde1cac390163f948241757f 
>   src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54 
>   src/tests/master_maintenance_tests.cpp 9edd74a876cd2933d5a5be590a7dd3d10bc54253 
> 
> 
> Diff: https://reviews.apache.org/r/59101/diff/5/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message