mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 59721: Refactored net::IP and added net::IPv4 and net::IPv6.
Date Sun, 11 Jun 2017 01:16:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59721/
-----------------------------------------------------------

(Updated June 11, 2017, 1:16 a.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
-------

Rebased based on BenH's patches.


Summary (updated)
-----------------

Refactored net::IP and added net::IPv4 and net::IPv6.


Bugs: MESOS-7488
    https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description (updated)
-------

Classes can now initialize the specialized classes whenever they need to
create explicit v4 and v6 addresses, rather than relying on the
`create/Try` semantics of net::IP.


Diffs (updated)
-----

  3rdparty/stout/include/stout/ip.hpp ad2bd922158eecd12b51b272d2a003b8ec8d3550 
  3rdparty/stout/tests/ip_tests.cpp 4c6f81bd53413360182b447ddb149a18e406870e 


Diff: https://reviews.apache.org/r/59721/diff/3/

Changes: https://reviews.apache.org/r/59721/diff/2-3/


Testing
-------

make check.


Thanks,

Avinash sridharan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message