mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 59860: Prevent allocating non-capable agents' resources to hierarchical roles.
Date Sat, 10 Jun 2017 00:09:51 GMT


> On June 8, 2017, 6:24 p.m., Neil Conway wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Lines 2087 (patched)
> > <https://reviews.apache.org/r/59860/diff/1/?file=1743639#file1743639line2087>
> >
> >     Do we really want to issue a warning here during every allocation cycle? This
could cause a ton of log messages. (I realize we use the same log level for the multi-role
case, but that is also debatable, IMO.)

It's not getting logged every allocation cycle, it's getting logged every time we trigger
the filter. Since this only gets logged when there is a framework with newer capabilities
than an agent, my thinking was that this wouldn't get logged at all the vast majority of the
time. And when it is getting logged, it's presumably temporary while a cluster is getting
upgraded. We could look into logging this only once per allocation cycle, since the filters
can fire *a lot* within each allocation cycle in some cases (e.g. all old agents, all new
frameworks).

In the past this kind of filtering occuring silently (for the 'checkpointing' bit) led to
a lot of confusion, there was nothing in the logs or the ui to help users. So it would be
nice to log it to some degree.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59860/#review177341
-----------------------------------------------------------


On June 7, 2017, 1:54 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59860/
> -----------------------------------------------------------
> 
> (Updated June 7, 2017, 1:54 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Neil Conway.
> 
> 
> Bugs: MESOS-7633
>     https://issues.apache.org/jira/browse/MESOS-7633
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 8ebdbc6a2b98feab7ce4d7f07b15d8fb92992270

>   src/tests/upgrade_tests.cpp b07426fa1e402c88a8a647eafdb77f6ebadd9959 
> 
> 
> Diff: https://reviews.apache.org/r/59860/diff/1/
> 
> 
> Testing
> -------
> 
> New tests + `make check`.
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message