mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 59874: Made `CheckerProcess` use a consistent description for log messages.
Date Fri, 09 Jun 2017 14:04:07 GMT


> On June 9, 2017, 3:48 a.m., Mesos Reviewbot Windows wrote:
> > Bad patch!
> > 
> > Reviews applied: [59874, 59902, 59873, 59872, 59871]
> > 
> > Failed command: python support/apply-reviews.py -n -r 59871
> > 
> > Error:
> > Traceback (most recent call last):
> >   File "support/apply-reviews.py", line 381, in <module>
> >     reviewboard()
> >   File "support/apply-reviews.py", line 360, in reviewboard
> >     apply_review()
> >   File "support/apply-reviews.py", line 126, in apply_review
> >     commit_patch()
> >   File "support/apply-reviews.py", line 225, in commit_patch
> >     shell(cmd, options['dry_run'])
> >   File "support/apply-reviews.py", line 111, in shell
> >     error_code = subprocess.call(command, stderr=subprocess.STDOUT, shell=True)
> >   File "C:\Python27\lib\subprocess.py", line 168, in call
> >     return Popen(*popenargs, **kwargs).wait()
> >   File "C:\Python27\lib\subprocess.py", line 390, in __init__
> >     errread, errwrite)
> >   File "C:\Python27\lib\subprocess.py", line 610, in _execute_child
> >     args = '{} /c "{}"'.format (comspec, args)
> > UnicodeEncodeError: 'ascii' codec can't encode character u'\xf3' in position 25:
ordinal not in range(128)
> > 
> > Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/80/console

Not sure what this means. I'll ask around but ignore it for now.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59874/#review177435
-----------------------------------------------------------


On June 9, 2017, 3:43 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59874/
> -----------------------------------------------------------
> 
> (Updated June 9, 2017, 3:43 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-7092
>     https://issues.apache.org/jira/browse/MESOS-7092
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made `CheckerProcess` use a consistent description for log messages.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker.cpp dcc3164f3b623de73bacf024ede95b40c48f7192 
>   src/checks/checker_process.hpp PRE-CREATION 
>   src/checks/checker_process.cpp PRE-CREATION 
>   src/checks/health_checker.cpp 9d8c8471caa05af3908d34315dbfed08a343c0f8 
> 
> 
> Diff: https://reviews.apache.org/r/59874/diff/3/
> 
> 
> Testing
> -------
> 
> Tests still pass on GNU/Linux.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message