mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 59902: Improved health checks validations.
Date Fri, 09 Jun 2017 13:59:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59902/#review177477
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On June 9, 2017, 3:42 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59902/
> -----------------------------------------------------------
> 
> (Updated June 9, 2017, 3:42 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-6916
>     https://issues.apache.org/jira/browse/MESOS-6916
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added validation for the "general" fields, such as `timeout_seconds`.
> 
> 
> Diffs
> -----
> 
>   src/checks/health_checker.cpp 9d8c8471caa05af3908d34315dbfed08a343c0f8 
>   src/tests/health_check_tests.cpp 7917a222daf6a8fbe2a5fe6657852e6ff6e699ba 
> 
> 
> Diff: https://reviews.apache.org/r/59902/diff/2/
> 
> 
> Testing
> -------
> 
> `make check` still passes on GNU/Linux
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message