mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 59935: Introduced a streaming function for a vector.
Date Fri, 09 Jun 2017 11:07:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59935/#review177462
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/type_utils.hpp
Lines 382-384 (original), 394-396 (patched)
<https://reviews.apache.org/r/59935/#comment251044>

    Not yours, but this one has a similar problem.
    
    I believe it should be possible to generalize this to e.g.,
    
        template <typename K, typename V>
        std::ostream& operator<<(
            std::ostream& stream,
            const hashmap<K, V>& map)
        {
          return stream << stringify(map);
        }


- Benjamin Bannier


On June 9, 2017, 1:18 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59935/
> -----------------------------------------------------------
> 
> (Updated June 9, 2017, 1:18 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced a streaming function for a vector.
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7 
>   src/common/type_utils.cpp 5f8e72b97d6766f9729079f6c6c013bc117cedb9 
> 
> 
> Diff: https://reviews.apache.org/r/59935/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message