> On June 8, 2017, 4:33 p.m., Alexander Rukletsov wrote:
> > src/checks/health_checker.cpp
> > Line 199 (original), 263-264 (patched)
> > <https://reviews.apache.org/r/59873/diff/2/?file=1744181#file1744181line275>
> >
> > I think we can do it `CheckerProcess`
Nope, because `CheckerProcess` only gets a subset of `HealthCheck`.
- Gastón
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59873/#review177306
-----------------------------------------------------------
On June 9, 2017, 3:36 a.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59873/
> -----------------------------------------------------------
>
> (Updated June 9, 2017, 3:36 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
>
>
> Bugs: MESOS-7092
> https://issues.apache.org/jira/browse/MESOS-7092
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `HealthChecker` now wraps a `CheckerProcess` and gets check status
> updates via a callback.
>
>
> Diffs
> -----
>
> src/checks/checker.cpp dcc3164f3b623de73bacf024ede95b40c48f7192
> src/checks/checker_process.hpp PRE-CREATION
> src/checks/checker_process.cpp PRE-CREATION
> src/checks/health_checker.hpp 25bf7e99bf5982fd7a6ff5012c231ff89fb7cb39
> src/checks/health_checker.cpp 9d8c8471caa05af3908d34315dbfed08a343c0f8
>
>
> Diff: https://reviews.apache.org/r/59873/diff/3/
>
>
> Testing
> -------
>
> Tests still pass on GNU/Linux.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
|