mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 59464: Add Fetcher task total and failed fetch metrics.
Date Fri, 09 Jun 2017 00:54:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59464/#review177428
-----------------------------------------------------------




src/slave/containerizer/fetcher.hpp
Lines 113-114 (patched)
<https://reviews.apache.org/r/59464/#comment250972>

    Normally, metrics live in the libprocess `Process` rather than the wrapper.
    
    Doing it this way will also make incrementing the counters a bit more intuitive (since
you'll be incrementing success/failure right after it happens, rather than when a future returns).



src/slave/containerizer/fetcher.cpp
Lines 71 (patched)
<https://reviews.apache.org/r/59464/#comment250968>

    A metrics prefix only makes sense when we're creating multiple processes.  In case of
the fetcher, there's only ever one of them, so it doesn't need a prefix.


- Joseph Wu


On June 6, 2017, 1:21 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59464/
> -----------------------------------------------------------
> 
> (Updated June 6, 2017, 1:21 p.m.)
> 
> 
> Review request for mesos and Mesos Reviewbot.
> 
> 
> Bugs: MESOS-7524
>     https://issues.apache.org/jira/browse/MESOS-7524
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add the Fetcher metrics to track the number of fetch requests
> sent to the Fetcher (`containerizer/fetcher/task_fetches_total`)
> and the number of errors reported by the Fetcher
> (`containerizer/fetcher/task_fetches_failed`).
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/fetcher.hpp efeadbf4b7804ea4c1e443d1e5212e303796ace4 
>   src/slave/containerizer/fetcher.cpp 770cad3e046e8a6d58b6bc9176eb7ecdbd340db4 
> 
> 
> Diff: https://reviews.apache.org/r/59464/diff/3/
> 
> 
> Testing
> -------
> 
> make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message