mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 59776: Added `CMAKE_FORWARD_ARGS` to `3rdparty/CMakeLists.txt`.
Date Thu, 08 Jun 2017 22:22:33 GMT


> On June 8, 2017, 8:56 p.m., Joseph Wu wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 67 (patched)
> > <https://reviews.apache.org/r/59776/diff/1/?file=1740998#file1740998line67>
> >
> >     Oh, I missed this in my first pass.
> >     
> >     This should be:
> >     ```
> >     -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
> >     ```

This... should be breaking things on Linux.

Furthermore, this should be:

```
if (NOT "${CMAKE_BUILD_TYPE}" STREQUAL "")
  string(APPEND CMAKE_FORWARD_ARGS -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE})
endif ()
```

As the variable [may be empty](https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html)
(and testing for an empty variable is annoying in CMake).


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59776/#review177373
-----------------------------------------------------------


On June 3, 2017, 7:31 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59776/
> -----------------------------------------------------------
> 
> (Updated June 3, 2017, 7:31 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-7618
>     https://issues.apache.org/jira/browse/MESOS-7618
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit also forwards the arguments to the projects where no other
> changes need to be made.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 96022ffaab94cfdfa3af0cadcfefc0c6518a6f6f 
> 
> 
> Diff: https://reviews.apache.org/r/59776/diff/1/
> 
> 
> Testing
> -------
> 
> This will require finally resolving https://issues.apache.org/jira/browse/MESOS-6350
unless we want to rewrite some logic.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message