mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 59788: Fixed glog `EXTERNAL` setup.
Date Thu, 08 Jun 2017 22:10:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59788/#review177399
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On June 3, 2017, 12:16 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59788/
> -----------------------------------------------------------
> 
> (Updated June 3, 2017, 12:16 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This was missed when the versions were reconciled. The `GLOG_VERSION` is
> now correct on every platform, so `EXTERNAL("glog"...)` can be reused.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 83406f271b52655fbda241f15d99a2c8268362f8

> 
> 
> Diff: https://reviews.apache.org/r/59788/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message