mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 59780: Fixed libevent CMake arguments.
Date Thu, 08 Jun 2017 22:06:05 GMT


> On June 8, 2017, 9:20 p.m., Joseph Wu wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 136-141 (original), 135-138 (patched)
> > <https://reviews.apache.org/r/59780/diff/1/?file=1741003#file1741003line136>
> >
> >     Looks like we can get rid of this entirely, as there is also some SSL flag setting
below.

Awesome.


> On June 8, 2017, 9:20 p.m., Joseph Wu wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 161-171 (original), 160-170 (patched)
> > <https://reviews.apache.org/r/59780/diff/1/?file=1741003#file1741003line163>
> >
> >     We could one-line this:
> >     `-DEVENT__DISABLE_OPENSSL=$<NOT:$<BOOL:ENABLE_SSL>>`

I'm not sure a generator expression is supported in this case. Sadly, generator expressions
use is restricted to certain inputs https://cmake.org/cmake/help/latest/manual/cmake-generator-expressions.7.html.
This being a variable sent to `ExternalProject_Add`... I don't think it'll work, but am willing
to try.


> On June 8, 2017, 9:20 p.m., Joseph Wu wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 173-178 (original), 172-177 (patched)
> > <https://reviews.apache.org/r/59780/diff/1/?file=1741003#file1741003line175>
> >
> >     We should be able to delete this line now that we have:
> >     `-DEVENT__BUILD_SHARED_LIBRARIES=${BUILD_SHARED_LIBS}`

Will need to double-check the libevent build system... I vaguely recall needing to explicitly
add `-fPIC` somewhere.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59780/#review177372
-----------------------------------------------------------


On June 3, 2017, 7:32 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59780/
> -----------------------------------------------------------
> 
> (Updated June 3, 2017, 7:32 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-6814 and MESOS-7618
>     https://issues.apache.org/jira/browse/MESOS-6814
>     https://issues.apache.org/jira/browse/MESOS-7618
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This removes the hard-coded `C_FLAGS` and properly forwards all
> arguments for each configuration. This also disables building the
> unnecessary benchmark, tests, and samples artifacts.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 96022ffaab94cfdfa3af0cadcfefc0c6518a6f6f 
> 
> 
> Diff: https://reviews.apache.org/r/59780/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message