mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 59782: Windows: Fixed curl build.
Date Thu, 08 Jun 2017 21:17:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59782/#review177381
-----------------------------------------------------------




cmake/CompilationConfigure.cmake
Lines 225-227 (patched)
<https://reviews.apache.org/r/59782/#comment250926>

    This was guarded in the other file, but why not here?
    
    Also, `curl.h` is only included in `stout/include/stout/net.hpp` at the moment, so it
doesn't seem too hard to just address this TODO now.


- Joseph Wu


On June 3, 2017, 12:33 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59782/
> -----------------------------------------------------------
> 
> (Updated June 3, 2017, 12:33 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-6814 and MESOS-7618
>     https://issues.apache.org/jira/browse/MESOS-6814
>     https://issues.apache.org/jira/browse/MESOS-7618
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of calling `msbuild` with hard-coded arguments, this instead
> uses the forwarded CMake arguments, and automatic `ExternalProject_Add`
> build.
> 
> The `-DCURL_STATIC_LIB` must be defined here so that every target which
> includes `glog.h` has the proper configuration.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 96022ffaab94cfdfa3af0cadcfefc0c6518a6f6f 
>   cmake/CompilationConfigure.cmake a0032a35d5c02cc6e7a5e90c187dae4954879f95 
> 
> 
> Diff: https://reviews.apache.org/r/59782/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message