mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 59777: Forwarded CMake arguments to ZooKeeper.
Date Thu, 08 Jun 2017 20:05:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59777/#review177362
-----------------------------------------------------------


Ship it!




LGTM.

- Joseph Wu


On June 3, 2017, 12:32 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59777/
> -----------------------------------------------------------
> 
> (Updated June 3, 2017, 12:32 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-6814 and MESOS-7618
>     https://issues.apache.org/jira/browse/MESOS-6814
>     https://issues.apache.org/jira/browse/MESOS-7618
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed the Linux configuration to respect `BUILD_SHARED_LIBS`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 96022ffaab94cfdfa3af0cadcfefc0c6518a6f6f 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 61f47948204a298fc0fbb6f39ad86d9e0dac1b3a

> 
> 
> Diff: https://reviews.apache.org/r/59777/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message