mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 59776: Added `CMAKE_FORWARD_ARGS` to `3rdparty/CMakeLists.txt`.
Date Thu, 08 Jun 2017 19:25:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59776/#review177353
-----------------------------------------------------------


Ship it!





3rdparty/CMakeLists.txt
Lines 69-71 (patched)
<https://reviews.apache.org/r/59776/#comment250909>

    For readability, I'd replace `l` with `lang` and `c` with `config`.



3rdparty/CMakeLists.txt
Lines 75-86 (patched)
<https://reviews.apache.org/r/59776/#comment250908>

    Hum.  I'm going to take some liberties with this comment :)
    
    * Going to move this comment above the `list(APPEND CMAKE_FORWARD_ARGS` and merge it with
the comment there.
    * Instead of mentioning `CMAKE_NOOP`, might be better to just note when `CMAKE_ARGS` will
be ignored.
    * The note about `SUB_DIR` seems out of place.


- Joseph Wu


On June 3, 2017, 12:31 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59776/
> -----------------------------------------------------------
> 
> (Updated June 3, 2017, 12:31 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-7618
>     https://issues.apache.org/jira/browse/MESOS-7618
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit also forwards the arguments to the projects where no other
> changes need to be made.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 96022ffaab94cfdfa3af0cadcfefc0c6518a6f6f 
> 
> 
> Diff: https://reviews.apache.org/r/59776/diff/1/
> 
> 
> Testing
> -------
> 
> This will require finally resolving https://issues.apache.org/jira/browse/MESOS-6350
unless we want to rewrite some logic.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message