mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 59859: Added `HIERARCHICAL_ROLE` agent capability.
Date Thu, 08 Jun 2017 18:23:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59859/#review177339
-----------------------------------------------------------




include/mesos/mesos.proto
Lines 809 (patched)
<https://reviews.apache.org/r/59859/#comment250887>

    Can we make this text a bit more generic? i.e., it also covers creating volumes under
a hierarchical role, not just launching tasks.



src/tests/master_tests.cpp
Line 4287 (original), 4287 (patched)
<https://reviews.apache.org/r/59859/#comment250882>

    No comma, "capabilities".



src/tests/slave_tests.cpp
Line 1543 (original), 1543 (patched)
<https://reviews.apache.org/r/59859/#comment250883>

    No comma, "capabilities".


- Neil Conway


On June 6, 2017, 9:53 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59859/
> -----------------------------------------------------------
> 
> (Updated June 6, 2017, 9:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Neil Conway.
> 
> 
> Bugs: MESOS-7632
>     https://issues.apache.org/jira/browse/MESOS-7632
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5f80170fcd3c05add8b6e9e3107cff062818c1dc 
>   include/mesos/v1/mesos.proto 4b528751006f709f841e44f48c9f5c2dc035b402 
>   src/common/protobuf_utils.hpp be2325f05b81b847fa592eff65175cbc99764fd6 
>   src/common/protobuf_utils.cpp 3fcaf786b29a00f003c10b0f1614a2c7eddc725d 
>   src/slave/constants.cpp 0fbcab8f1cee4183dfd4c25984cd27f8baabda44 
>   src/tests/master_tests.cpp 490d7ed4b275ebf5ff6956f7d40dbea3ce3b63e2 
>   src/tests/slave_tests.cpp b5141d7013acdd6e236606ef3d9b1953b14d373a 
>   src/tests/upgrade_tests.cpp b07426fa1e402c88a8a647eafdb77f6ebadd9959 
> 
> 
> Diff: https://reviews.apache.org/r/59859/diff/1/
> 
> 
> Testing
> -------
> 
> Updated existing tests / `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message