mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 58510: Added two tests for hierarchical reservation.
Date Thu, 08 Jun 2017 18:23:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58510/#review177346
-----------------------------------------------------------




src/tests/hierarchical_allocator_tests.cpp
Lines 4615 (patched)
<https://reviews.apache.org/r/58510/#comment250902>

    Needs to be updated for the change to the `addFramework` API method.



src/tests/reservation_tests.cpp
Lines 2401 (patched)
<https://reviews.apache.org/r/58510/#comment250906>

    I have various minor gripes about how this test is written :)
    
    When the clock is paused, I think it is better to first advance the clock to ensure the
agent has registered. Then register the framework; we should then get an offer at precisely
that point (w/o waiting for batch alloc). As written, advancing the clock for the batch alloc
is actually what triggers the agent to register, which is fragile (what if agent registration
backoff is > batch alloc interval?).
    
    i.e., I'd adjust the test as follows: https://gist.github.com/neilconway/2f11988222cd8fb9583905624cb4ddd5



src/tests/reservation_tests.cpp
Lines 2424 (patched)
<https://reviews.apache.org/r/58510/#comment250905>

    This should be unnecessary; waiting for the first offer is sufficient.



src/tests/reservation_tests.cpp
Lines 2430 (patched)
<https://reviews.apache.org/r/58510/#comment250903>

    Settle should be unnecessary.


- Neil Conway


On April 18, 2017, 3:45 p.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58510/
> -----------------------------------------------------------
> 
> (Updated April 18, 2017, 3:45 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-7149
>     https://issues.apache.org/jira/browse/MESOS-7149
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added two tests for hierarchical reservation.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 33e7b455f8664858eb4f03727b076a10c80cd6e0

>   src/tests/reservation_tests.cpp 4504831d77c1bfcf5f2ddf6d28cd45dea2c421ad 
> 
> 
> Diff: https://reviews.apache.org/r/58510/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message