mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 59873: Refactored `HealthChecker` to use `CheckerProcess`.
Date Thu, 08 Jun 2017 17:00:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59873/#review177328
-----------------------------------------------------------




src/checks/health_checker.cpp
Lines 112 (patched)
<https://reviews.apache.org/r/59873/#comment250870>

    Kill this line?



src/checks/health_checker.cpp
Lines 114 (patched)
<https://reviews.apache.org/r/59873/#comment250871>

    Kill this line?



src/checks/health_checker.cpp
Lines 115-117 (patched)
<https://reviews.apache.org/r/59873/#comment250868>

    Do you really need `if` here?



src/checks/health_checker.cpp
Lines 124 (patched)
<https://reviews.apache.org/r/59873/#comment250869>

    Kill this line?



src/checks/health_checker.cpp
Line 116 (original), 146 (patched)
<https://reviews.apache.org/r/59873/#comment250872>

    Kill this line?



src/checks/health_checker.cpp
Lines 156 (patched)
<https://reviews.apache.org/r/59873/#comment250873>

    Kill this line?


- Alexander Rukletsov


On June 7, 2017, 11:56 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59873/
> -----------------------------------------------------------
> 
> (Updated June 7, 2017, 11:56 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-7092
>     https://issues.apache.org/jira/browse/MESOS-7092
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `HealthChecker` now wraps a `CheckerProcess` and gets check status
> updates via a callback.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker.cpp dcc3164f3b623de73bacf024ede95b40c48f7192 
>   src/checks/checker_process.hpp PRE-CREATION 
>   src/checks/checker_process.cpp PRE-CREATION 
>   src/checks/health_checker.hpp 25bf7e99bf5982fd7a6ff5012c231ff89fb7cb39 
>   src/checks/health_checker.cpp 9d8c8471caa05af3908d34315dbfed08a343c0f8 
> 
> 
> Diff: https://reviews.apache.org/r/59873/diff/2/
> 
> 
> Testing
> -------
> 
> Tests still pass on GNU/Linux.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message