mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 59873: Refactored `HealthChecker` to use `CheckerProcess`.
Date Wed, 07 Jun 2017 23:56:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59873/
-----------------------------------------------------------

(Updated June 7, 2017, 11:56 p.m.)


Review request for mesos, Alexander Rukletsov and Vinod Kone.


Changes
-------

Addressed feedback.


Bugs: MESOS-7092
    https://issues.apache.org/jira/browse/MESOS-7092


Repository: mesos


Description
-------

`HealthChecker` now wraps a `CheckerProcess` and gets check status
updates via a callback.


Diffs (updated)
-----

  src/checks/checker.cpp dcc3164f3b623de73bacf024ede95b40c48f7192 
  src/checks/checker_process.hpp PRE-CREATION 
  src/checks/checker_process.cpp PRE-CREATION 
  src/checks/health_checker.hpp 25bf7e99bf5982fd7a6ff5012c231ff89fb7cb39 
  src/checks/health_checker.cpp 9d8c8471caa05af3908d34315dbfed08a343c0f8 


Diff: https://reviews.apache.org/r/59873/diff/2/

Changes: https://reviews.apache.org/r/59873/diff/1-2/


Testing
-------

Tests still pass on GNU/Linux.


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message