mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 59865: Fixed conversion warning in `duration.hpp`.
Date Wed, 07 Jun 2017 21:04:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59865/#review177225
-----------------------------------------------------------



Patch looks great!

Reviews applied: [59865]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On June 7, 2017, 8 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59865/
> -----------------------------------------------------------
> 
> (Updated June 7, 2017, 8 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-7459
>     https://issues.apache.org/jira/browse/MESOS-7459
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> While `ns()` and our other types are `int64_t`, the variables to which
> we're assigning are (by definition of `struct timeval`) a `time_t` or a
> `long` (depending on platform). We cast it because there is no
> alternative, and we otherwise generate hundreds of warnings. We cast to
> `decltype(...)` because the type is different depending on platform.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/duration.hpp 138993e25c51efc82d447fe82037bf3a5fe7fd91

> 
> 
> Diff: https://reviews.apache.org/r/59865/diff/2/
> 
> 
> Testing
> -------
> 
> Built `stout-tests` on Windows and Linux, no more `duration.hpp` warnings.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message