mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 59892: Cleaned up two agent tests.
Date Wed, 07 Jun 2017 20:35:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59892/#review177221
-----------------------------------------------------------


Ship it!





src/tests/slave_tests.cpp
Line 7233 (original), 7235 (patched)
<https://reviews.apache.org/r/59892/#comment250765>

    Indented too much here; I fixed this before committing.


- Neil Conway


On June 7, 2017, 8:30 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59892/
> -----------------------------------------------------------
> 
> (Updated June 7, 2017, 8:30 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch addresses some style issues in two agent tests,
> `SlaveTest.DisconnectedExecutorDropsMessages` and
> `SlaveTest.ExecutorReregistrationTimeoutFlag`.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp b5141d7013acdd6e236606ef3d9b1953b14d373a 
> 
> 
> Diff: https://reviews.apache.org/r/59892/diff/2/
> 
> 
> Testing
> -------
> 
> `bin/mesos-tests.sh --gtest_filter="*DisconnectedExecutorDropsMessages*:*ExecutorReregistrationTimeoutFlag*"
--gtest_repeat=-1 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message