mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 59891: Windows: Use `cmd /C exit 1` instead of `false`.
Date Wed, 07 Jun 2017 19:50:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59891/
-----------------------------------------------------------

(Updated June 7, 2017, 7:50 p.m.)


Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.


Changes
-------

Change style.


Bugs: MESOS-7638
    https://issues.apache.org/jira/browse/MESOS-7638


Repository: mesos


Description
-------

This fixes tests that pass but emit error messages due to `false` not
existing as a command on Windows.


Diffs (updated)
-----

  src/tests/health_check_tests.cpp 7917a222daf6a8fbe2a5fe6657852e6ff6e699ba 


Diff: https://reviews.apache.org/r/59891/diff/2/

Changes: https://reviews.apache.org/r/59891/diff/1-2/


Testing
-------

Trying to split out fixes I made in my fix-long-paths branch that can be applied sooner, so
this has been tested quite thoroughly but with other patches.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message