mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 59882: Cleared ResourceProviderID with createStrippedScalarQuantity.
Date Wed, 07 Jun 2017 18:44:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59882/
-----------------------------------------------------------

(Updated June 7, 2017, 8:44 p.m.)


Review request for mesos, Jie Yu and Neil Conway.


Changes
-------

Also updated v1 version.


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  src/common/resources.cpp 6f963d4aa58cf4e5b5cb8bed0be314c806eac1d7 
  src/tests/resources_tests.cpp eb8b551dab6313451a7cbe02af0c348f5a95ee3d 
  src/v1/resources.cpp d740bd1f637647aa6264bcac1d9f47ac089c8c50 


Diff: https://reviews.apache.org/r/59882/diff/2/

Changes: https://reviews.apache.org/r/59882/diff/1-2/


Testing
-------

`make check`

I also compared `Resources`-related benchmarks before and after applying this fix. No clear
movement was visible in the timings beyond noise.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message