mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 59878: Included ResourceProviderID in Resource equality check.
Date Wed, 07 Jun 2017 17:08:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59878/#review177188
-----------------------------------------------------------




src/common/resources.cpp
Lines 263 (patched)
<https://reviews.apache.org/r/59878/#comment250731>

    Also needs to update the copy of this code in `v1/`.



src/common/resources.cpp
Lines 270 (patched)
<https://reviews.apache.org/r/59878/#comment250730>

    Only one newline.


- Neil Conway


On June 7, 2017, 11:10 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59878/
> -----------------------------------------------------------
> 
> (Updated June 7, 2017, 11:10 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Included ResourceProviderID in Resource equality check.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp 6f963d4aa58cf4e5b5cb8bed0be314c806eac1d7 
> 
> 
> Diff: https://reviews.apache.org/r/59878/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` (Fedora 25, clang-trunk)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message