mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 59874: Made `CheckerProcess` use a consistent description for log messages.
Date Wed, 07 Jun 2017 16:49:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59874/#review177180
-----------------------------------------------------------




src/checks/checker_process.hpp
Lines 58 (patched)
<https://reviews.apache.org/r/59874/#comment250726>

    I'd rather keep `id` (or `name`) in each class and pass it down to `CheckerProcess`.



src/checks/checker_process.hpp
Lines 140 (patched)
<https://reviews.apache.org/r/59874/#comment250727>

    If you inherited `id` (`name`), you could update it here instead of having a separate
`buildName` function for this and an extra `description` field.


- Alexander Rukletsov


On June 7, 2017, 5:17 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59874/
> -----------------------------------------------------------
> 
> (Updated June 7, 2017, 5:17 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-7092
>     https://issues.apache.org/jira/browse/MESOS-7092
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made `CheckerProcess` use a consistent description for log messages.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker.cpp dcc3164f3b623de73bacf024ede95b40c48f7192 
>   src/checks/checker_process.hpp PRE-CREATION 
>   src/checks/checker_process.cpp PRE-CREATION 
>   src/checks/health_checker.cpp 9d8c8471caa05af3908d34315dbfed08a343c0f8 
> 
> 
> Diff: https://reviews.apache.org/r/59874/diff/1/
> 
> 
> Testing
> -------
> 
> Tests still pass on GNU/Linux.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message