mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <>
Subject Re: Review Request 59605: Used glog for logging in executors.
Date Tue, 06 Jun 2017 11:24:58 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated June 6, 2017, 11:24 a.m.)

Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and Till

Bugs: MESOS-6961

Repository: mesos


The rule for choosing between glog and cout is described by MESOS-7586.

Diffs (updated)

  src/docker/executor.cpp 464a74859e0f477ec2e5525a5fc726ea420a00a2 
  src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574 
  src/launcher/executor.cpp 9ac3c3d84c0ec47954c5c72228ad0b8795ff3eec 




1. make check (mac os x 10.12, fedora 25)
2. jenkins:

3. I've temporarily modified NoTaskKillingCapability from command_executor_tests.cpp to launch
command "sleep 0.1" (as well as "sleep 0"),
then to wait for a task completion. The test was launched in an endless loop:

GLOG_v=1 ./bin/  --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0"

I've run this test multiple times for a while both on mac os and Fedora linux. Race condition
problem described in a jira ticket wasn't reproduced.


Andrei Budnik

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message