mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 59547: Rename ContainerLaunchInfo `capabilities` field.
Date Mon, 05 Jun 2017 16:16:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59547/
-----------------------------------------------------------

(Updated June 5, 2017, 4:16 p.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
-------

Rebased.


Bugs: MESOS-7476
    https://issues.apache.org/jira/browse/MESOS-7476


Repository: mesos


Description
-------

Rename the ContainerLaunchInfo `capabilities` field to
`effective_capabilities` since it is intended to be the set of
capabilities we actually make effective in the launched task.


Diffs (updated)
-----

  include/mesos/slave/containerizer.proto 03a983ed5fde5342408236f6acfca69d33a4265f 
  src/launcher/executor.cpp 9ac3c3d84c0ec47954c5c72228ad0b8795ff3eec 
  src/slave/containerizer/mesos/containerizer.cpp f3e6210eccd4a6b445ffd4447e69526d424ea36d

  src/slave/containerizer/mesos/isolators/linux/capabilities.cpp 60d22aa877c1ab62a08222e5efe8800e337684da

  src/slave/containerizer/mesos/launch.cpp f48d294a0a832dfe248c4a83849ee5a63cb76bce 


Diff: https://reviews.apache.org/r/59547/diff/2/

Changes: https://reviews.apache.org/r/59547/diff/1-2/


Testing
-------

make check (Fedora 25)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message