mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 59787: Windows: Fixed runtime library linkage.
Date Sat, 03 Jun 2017 19:34:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59787/
-----------------------------------------------------------

(Updated June 3, 2017, 7:34 p.m.)


Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li.


Bugs: MESOS-5994, MESOS-7157 and MESOS-7618
    https://issues.apache.org/jira/browse/MESOS-5994
    https://issues.apache.org/jira/browse/MESOS-7157
    https://issues.apache.org/jira/browse/MESOS-7618


Repository: mesos


Description
-------

Instead of hard-coding the static version of the runtime library, this
patch uses the runtime library based on `BUILD_SHARED_LIBS` and
`CMAKE_BUILD_TYPE`, and sets all the appropriate configuration and
language variables.


Diffs
-----

  cmake/CompilationConfigure.cmake a0032a35d5c02cc6e7a5e90c187dae4954879f95 


Diff: https://reviews.apache.org/r/59787/diff/1/


Testing
-------

Thisi properly switches the CRT linked between Debug and Release configurations.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message