mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 59771: Windows: Removed VsBuildCommand.
Date Sat, 03 Jun 2017 19:30:42 GMT


> On June 3, 2017, 7:27 p.m., Mesos Reviewbot Windows wrote:
> > Patch looks great!
> > 
> > Reviews applied: [59771]
> > 
> > Passed command: support\windows-build.bat

Hm... shouldn't this be testing the last patch in the chain? Oh, this was posted before the
others. Interesting...


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59771/#review176870
-----------------------------------------------------------


On June 3, 2017, 7:25 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59771/
> -----------------------------------------------------------
> 
> (Updated June 3, 2017, 7:25 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-7618
>     https://issues.apache.org/jira/browse/MESOS-7618
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This CMake function was previously used to generate a `.bat` script on
> Windows that would build the project. However, this is unnecessary, as
> the command `cmake --build .` performs the same function, and the
> generated script was not being used.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake c7b795313ddb604a32bbb7666b2352b6b4aa5df7

>   CMakeLists.txt de463fb30fa751618e8a060a8ecf61d943c5e11e 
>   cmake/MesosConfigure.cmake e44f662b6da71caa493cc568a5e5bcb0a608a8b1 
> 
> 
> Diff: https://reviews.apache.org/r/59771/diff/1/
> 
> 
> Testing
> -------
> 
> All testing for the chain covered here:
> 
> Tested the build and execution of `stout-tests`, `libprocess-tests`, and `mesos-tests`
in `Debug` and `Release` configurations (obviously through CMake) on both Windows and Linux
(CentOS 7 using `cmake3`).
> 
> ```
> Linux (CentOS 7):
> cmake3 .. && ctest
> Test project /home/andschwa/src/mesos/build
>     Start 1: StoutTests
> 1/3 Test #1: StoutTests .......................   Passed    0.29 sec
>     Start 2: ProcessTests
> 2/3 Test #2: ProcessTests .....................   Passed    0.83 sec
>     Start 3: MesosTests
> 3/3 Test #3: MesosTests .......................   Passed  271.24 sec
> 
> cmake3 .. -DCMAKE_BUILD_TYPE=Release && ctest
> Test project /home/andschwa/src/mesos/build_release
>     Start 1: StoutTests
> 1/3 Test #1: StoutTests .......................   Passed    0.20 sec
>     Start 2: ProcessTests
> 2/3 Test #2: ProcessTests .....................   Passed    0.58 sec
>     Start 3: MesosTests
> 3/3 Test #3: MesosTests .......................   Passed  234.94 sec
> ```
> 
> Verified on Windows that all `3rdparty` dependencies properly build either `Debug` or
`Release` libraries, and link properly. Caveat: `mesos-tests` is not built in a configuration-dependent
folder, so swapping configurations rebuilds it (though this is not true of the other tests).
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message