mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 59786: Set default library linkage based on `BUILD_SHARED_LIBS`.
Date Sat, 03 Jun 2017 19:05:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59786/
-----------------------------------------------------------

Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li.


Bugs: MESOS-5994
    https://issues.apache.org/jira/browse/MESOS-5994


Repository: mesos


Description
-------

Instead of hard-coding this based on the platform, this sets it based on
the canonical `BUILD_SHARED_LIBS` option. When not set, the default
linkage is platform-specific.


Diffs
-----

  cmake/CompilationConfigure.cmake a0032a35d5c02cc6e7a5e90c187dae4954879f95 
  cmake/MesosConfigure.cmake e44f662b6da71caa493cc568a5e5bcb0a608a8b1 


Diff: https://reviews.apache.org/r/59786/diff/1/


Testing
-------

Note that building with shared libraries on Windows is not quite supported yet; this (and
the rest of the series) just gets us a lot closer.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message