mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 59772: Removed `ENABLE_OPTIMIZE` CMake option.
Date Sat, 03 Jun 2017 18:49:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59772/
-----------------------------------------------------------

Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li.


Repository: mesos


Description
-------

This option was added as a mapping from the Autotools
`--enable-optimize` flag. However, it does not work as expected, since
CMake automatically adds platform-specific optimization flags depending
on the build configuration. That is, Debug builds are not optimized, and
Release builds are optimized. Therefore, all this option did was to
unnecessarily add optimizations to the Debug build, and fail to disable
optimizations for the Release build.


Diffs
-----

  cmake/CompilationConfigure.cmake a0032a35d5c02cc6e7a5e90c187dae4954879f95 


Diff: https://reviews.apache.org/r/59772/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message