mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 59771: Windows: Removed VsBuildCommand.
Date Sat, 03 Jun 2017 18:48:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59771/
-----------------------------------------------------------

Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li.


Repository: mesos


Description
-------

This CMake function was previously used to generate a `.bat` script on
Windows that would build the project. However, this is unnecessary, as
the command `cmake --build .` performs the same function, and the
generated script was not being used.


Diffs
-----

  3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake c7b795313ddb604a32bbb7666b2352b6b4aa5df7

  CMakeLists.txt de463fb30fa751618e8a060a8ecf61d943c5e11e 
  cmake/MesosConfigure.cmake e44f662b6da71caa493cc568a5e5bcb0a608a8b1 


Diff: https://reviews.apache.org/r/59771/diff/1/


Testing
-------

All testing is reported at the end of the chain.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message