mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 59764: Ignore registration attempts by agents with misconfigured domain.
Date Fri, 02 Jun 2017 20:12:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59764/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-7612
    https://issues.apache.org/jira/browse/MESOS-7612


Repository: mesos


Description
-------

We expect the master's domain to be configured first, then the domain of
the agents to be configured. Therefore, if an agent with configured
domain attempts to register or re-register with a master that does not
have a configured domain, the registration attempt should be ignored.
This is important, because the master would have no way of determining
whether the agent is "remote" or not, which might result in placing
inappropriate workloads on it.


Diffs
-----

  src/master/master.cpp c66907bd55cb2eb549ec89f048d41376df556eb9 
  src/tests/master_tests.cpp 490d7ed4b275ebf5ff6956f7d40dbea3ce3b63e2 


Diff: https://reviews.apache.org/r/59764/diff/1/


Testing
-------

`make check`

Manual testing.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message