mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 59100: Enabled authorization for v1 API call GET_MAINTENANCE_SCHEDULE.
Date Fri, 02 Jun 2017 10:00:30 GMT


> On June 2, 2017, 3:43 a.m., Greg Mann wrote:
> > src/master/http.cpp
> > Lines 4222-4240 (patched)
> > <https://reviews.apache.org/r/59100/diff/4/?file=1731539#file1731539line4222>
> >
> >     Simply copying into a new `Schedule` message is inefficient, but probably OK
for now, as it's more readable and the output of this endpoint may not become too large.
> >     
> >     I'm mostly just leaving this comment for posterity, to note that we may want
to use the more sophisiticated JSON writer-based filtering in the future if performance becomes
an issue, as we do in the `/state` handler.

I thought the same when I built it, but then I saw other related functons, like `getMaintenanceStatus`
do something similar.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59100/#review176702
-----------------------------------------------------------


On June 1, 2017, 4:57 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59100/
> -----------------------------------------------------------
> 
> (Updated June 1, 2017, 4:57 p.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-7415
>     https://issues.apache.org/jira/browse/MESOS-7415
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enables the use of authorization for the `GET_MAINTENANCE_SCHEDULE`
> v1 API call, using the ACL `GetMaintenanceSchedule` and the action
> of the same name as the API call.
> 
> It also updates the ApiTests to take into account the authorization
> case.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 7060b8fa53e0682681c50e051908ffbbf50fb7da 
>   src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732 
>   src/tests/api_tests.cpp faf3242f9c86d866c4bb5e457fcfe47c1063cc09 
> 
> 
> Diff: https://reviews.apache.org/r/59100/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message