mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 58950: Made persistent volume endpoints tests independent from allocator.
Date Fri, 02 Jun 2017 09:27:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58950/#review176743
-----------------------------------------------------------




src/tests/persistent_volume_endpoints_tests.cpp
Lines 827 (patched)
<https://reviews.apache.org/r/58950/#comment250206>

    Let's remove this.



src/tests/persistent_volume_endpoints_tests.cpp
Line 1067 (original), 1032 (patched)
<https://reviews.apache.org/r/58950/#comment250207>

    s/befor/before



src/tests/persistent_volume_endpoints_tests.cpp
Lines 1034 (patched)
<https://reviews.apache.org/r/58950/#comment250208>

    No need for this.



src/tests/persistent_volume_endpoints_tests.cpp
Line 1286 (original), 1249 (patched)
<https://reviews.apache.org/r/58950/#comment250209>

    s/befor/before/



src/tests/persistent_volume_endpoints_tests.cpp
Lines 1251 (patched)
<https://reviews.apache.org/r/58950/#comment250210>

    Let's not call it explicitly.



src/tests/persistent_volume_endpoints_tests.cpp
Lines 1848-1849 (original), 1791-1793 (patched)
<https://reviews.apache.org/r/58950/#comment250211>

    I believe `slaveId1` is more common in our code base. Feel free to change it, preferably
in a separate patch : )


- Alexander Rukletsov


On May 30, 2017, 10:22 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58950/
> -----------------------------------------------------------
> 
> (Updated May 30, 2017, 10:22 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7388
>     https://issues.apache.org/jira/browse/MESOS-7388
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The tests in the case often require an agent ID. To obtain the ID they
> were using a mock allocator to grab agent ID, but not other operations
> with the allocator were performed.
> 
> Instead we now just capture the SlaveRegisteredMessage in order to
> learn an agent's ID.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_endpoints_tests.cpp 21136b29d7eeee24959527b889f52611baee0668

> 
> 
> Diff: https://reviews.apache.org/r/58950/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`, also in repetition.
> 
> While this patch is part of this series since later patches depend on it, it could be
commited independently.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message