| Aaron Wood via Review Board |
Review Request 59413: Fix constexpr compilation failure with GCC 7.1. |
Fri, 19 May, 18:45 |
| Mesos Reviewbot Windows |
Re: Review Request 59413: Fix constexpr compilation failure with GCC 7.1. |
Fri, 19 May, 18:45 |
| Neil Conway |
Re: Review Request 59413: Fix constexpr compilation failure with GCC 7.1. |
Fri, 19 May, 18:51 |
| Aaron Wood via Review Board |
Re: Review Request 59413: Fix constexpr compilation failure with GCC 7.1. |
Fri, 19 May, 18:56 |
| Benjamin Bannier |
Re: Review Request 59413: Fix constexpr compilation failure with GCC 7.1. |
Fri, 19 May, 19:09 |
| Aaron Wood via Review Board |
Re: Review Request 59413: Fix constexpr compilation failure with GCC 7.1. |
Fri, 19 May, 19:21 |
| Aaron Wood via Review Board |
Re: Review Request 59413: Fix constexpr compilation failure with GCC 7.1. |
Fri, 19 May, 18:51 |
| Mesos Reviewbot Windows |
Re: Review Request 59413: Fix constexpr compilation failure with GCC 7.1. |
Fri, 19 May, 18:51 |
| Aaron Wood via Review Board |
Re: Review Request 59413: Fix constexpr compilation failure with GCC 7.1. |
Fri, 19 May, 18:58 |
| Aaron Wood via Review Board |
Re: Review Request 59413: Fix constexpr compilation failure with GCC 7.1. |
Fri, 19 May, 19:00 |
| James Peach |
Re: Review Request 59413: Fix constexpr compilation failure with GCC 7.1. |
Mon, 22 May, 16:12 |
| Aaron Wood via Review Board |
Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1. |
Mon, 22 May, 16:52 |
| Aaron Wood via Review Board |
Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1. |
Mon, 22 May, 16:56 |
| James Peach |
Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1. |
Thu, 25 May, 00:21 |
| Aaron Wood via Review Board |
Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1. |
Thu, 25 May, 16:42 |
| Aaron Wood via Review Board |
Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1. |
Thu, 25 May, 18:13 |
| James Peach |
Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1. |
Fri, 26 May, 00:12 |
| Mesos Reviewbot Windows |
Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1. |
Fri, 26 May, 00:29 |
| Mesos Reviewbot |
Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1. |
Fri, 26 May, 03:17 |
| Joseph Wu |
Review Request 59419: Updated mesos-local work directory structure. |
Fri, 19 May, 22:07 |
| Jie Yu |
Re: Review Request 59419: Updated mesos-local work directory structure. |
Mon, 22 May, 17:49 |
| Joseph Wu |
Review Request 59420: Added some comments to ContainerConfig protobuf. |
Fri, 19 May, 22:09 |
| Jie Yu |
Re: Review Request 59420: Added some comments to ContainerConfig protobuf. |
Mon, 22 May, 18:02 |
| Anand Mazumdar |
Review Request 59428: Moved a couple of logging lines to `INFO` level. |
Sat, 20 May, 16:44 |
| Till Toenshoff |
Re: Review Request 59428: Moved a couple of logging lines to `INFO` level. |
Sun, 21 May, 08:44 |
| Vinod Kone |
Re: Review Request 59428: Moved a couple of logging lines to `INFO` level. |
Tue, 23 May, 20:11 |
| Anand Mazumdar |
Re: Review Request 59428: Moved a couple of logging lines to `INFO` level. |
Tue, 23 May, 20:14 |
| Anand Mazumdar |
Re: Review Request 59428: Moved a couple of logging lines to `WARNING` level. |
Tue, 23 May, 20:21 |
| Anand Mazumdar |
Re: Review Request 59428: Moved a couple of logging lines to `WARNING` level. |
Tue, 23 May, 20:20 |
| Vinod Kone |
Re: Review Request 59428: Moved a couple of logging lines to `WARNING` level. |
Tue, 23 May, 20:35 |
| Benjamin Mahler |
Re: Review Request 59428: Moved a couple of logging lines to `WARNING` level. |
Tue, 23 May, 21:31 |
| Anand Mazumdar |
Re: Review Request 59428: Moved a couple of logging lines to `WARNING` level. |
Tue, 23 May, 21:46 |
| Anand Mazumdar |
Re: Review Request 59428: Moved a couple of logging lines to `WARNING` level. |
Tue, 23 May, 21:58 |
| Anand Mazumdar |
Re: Review Request 59428: Moved a couple of logging lines to `WARNING` level. |
Tue, 23 May, 21:57 |
| Mesos Reviewbot |
Re: Review Request 59428: Moved a couple of logging lines to `WARNING` level. |
Wed, 24 May, 10:29 |
| Vinod Kone |
Re: Review Request 59428: Moved a couple of logging lines to `WARNING` level. |
Wed, 31 May, 18:14 |
| Mesos Reviewbot Windows |
Re: Review Request 59428: Moved a couple of logging lines to `WARNING` level. |
Wed, 31 May, 18:15 |
| Jiang Yan Xu |
Review Request 59434: Added a few master log lines. |
Mon, 22 May, 05:38 |
| James Peach |
Re: Review Request 59434: Added a few master log lines. |
Mon, 22 May, 16:42 |
| Jiang Yan Xu |
Re: Review Request 59434: Added a few master log lines. |
Mon, 22 May, 20:56 |
| James Peach |
Re: Review Request 59434: Added a few master log lines. |
Tue, 23 May, 22:51 |
| Alexander Rojas |
Review Request 59453: Renamed RegisterAgent.agent to RegisterAgent.agents in acls.proto. |
Mon, 22 May, 15:53 |
| Neil Conway |
Re: Review Request 59453: Renamed RegisterAgent.agent to RegisterAgent.agents in acls.proto. |
Tue, 23 May, 17:53 |
| Alexander Rojas |
Re: Review Request 59453: Renamed RegisterAgent.agent to RegisterAgent.agents in acls.proto. |
Wed, 24 May, 08:08 |
| Alexander Rojas |
Re: Review Request 59453: Renamed RegisterAgent.agent to RegisterAgent.agents in acls.proto. |
Wed, 24 May, 08:12 |
| Jiang Yan Xu |
Re: Review Request 59453: Renamed RegisterAgent.agent to RegisterAgent.agents in acls.proto. |
Wed, 24 May, 17:26 |
| Jiang Yan Xu |
Re: Review Request 59453: Renamed RegisterAgent.agent to RegisterAgent.agents in acls.proto. |
Wed, 24 May, 17:35 |
| Jiang Yan Xu |
Re: Review Request 59453: Renamed RegisterAgent.agent to RegisterAgent.agents in acls.proto. |
Tue, 30 May, 20:43 |
| Aaron Wood via Review Board |
Review Request 59454: Adjust test to account for changes to bytes.hpp. |
Mon, 22 May, 16:56 |
| Aaron Wood via Review Board |
Re: Review Request 59454: Adjust tests to account for GCC 7.1 fix in bytes.hpp. |
Mon, 22 May, 17:24 |
| James Peach |
Re: Review Request 59454: Adjust tests to account for GCC 7.1 fix in bytes.hpp. |
Tue, 23 May, 22:50 |
| Aaron Wood via Review Board |
Re: Review Request 59454: Adjust tests to account for GCC 7.1 fix in bytes.hpp. |
Wed, 24 May, 17:53 |
| Aaron Wood via Review Board |
Re: Review Request 59454: Adjust tests to account for GCC 7.1 fix in bytes.hpp. |
Wed, 24 May, 17:53 |
| James Peach |
Re: Review Request 59454: Adjust tests to account for GCC 7.1 fix in bytes.hpp. |
Thu, 25 May, 00:15 |
| James Peach |
Review Request 59458: Belay the reregistration validation if it is already in flight. |
Mon, 22 May, 18:12 |
| Neil Conway |
Re: Review Request 59458: Belay the reregistration validation if it is already in flight. |
Mon, 22 May, 18:33 |
| James Peach |
Re: Review Request 59458: Avoid validation of agent re-registration message if possible. |
Mon, 22 May, 18:37 |
| Greg Mann |
Review Request 59460: Added new agent flag 'executor_reregister_timeout'. |
Mon, 22 May, 18:35 |
| Greg Mann |
Re: Review Request 59460: Added new agent flag 'executor_reregister_timeout'. |
Mon, 22 May, 18:46 |
| Vinod Kone |
Re: Review Request 59460: Added new agent flag 'executor_reregister_timeout'. |
Mon, 22 May, 21:39 |
| Benjamin Mahler |
Re: Review Request 59460: Added new agent flag 'executor_reregister_timeout'. |
Mon, 22 May, 22:03 |
| Greg Mann |
Re: Review Request 59460: Added new agent flag 'executor_reregister_timeout'. |
Mon, 22 May, 22:36 |
| Greg Mann |
Re: Review Request 59460: Added new agent flag 'executor_reregistration_timeout'. |
Mon, 22 May, 22:36 |
| Greg Mann |
Review Request 59461: Added 'executor_reregister_timeout' agent flag to the tests. |
Mon, 22 May, 18:44 |
| Greg Mann |
Re: Review Request 59461: Added 'executor_reregister_timeout' agent flag to the tests. |
Mon, 22 May, 18:46 |
| Vinod Kone |
Re: Review Request 59461: Added 'executor_reregister_timeout' agent flag to the tests. |
Mon, 22 May, 21:44 |
| Greg Mann |
Re: Review Request 59461: Added 'executor_reregister_timeout' agent flag to the tests. |
Mon, 22 May, 22:39 |
| James Peach |
Review Request 59464: Add fetch success metric. |
Mon, 22 May, 21:15 |
| Joseph Wu |
Re: Review Request 59464: Add Fetcher total and success metrics. |
Tue, 23 May, 01:04 |
| James Peach |
Re: Review Request 59464: Add Fetcher total and success metrics. |
Tue, 23 May, 22:43 |
| Benjamin Mahler |
Re: Review Request 59464: Add Fetcher total and success metrics. |
Tue, 30 May, 20:07 |
| Greg Mann |
Review Request 59463: Added test for agent ping timeout during agent recovery. |
Mon, 22 May, 21:17 |
| Benjamin Mahler |
Re: Review Request 59463: Added test for agent ping timeout during agent recovery. |
Mon, 22 May, 22:23 |
| Vinod Kone |
Re: Review Request 59463: Added test for agent ping timeout during agent recovery. |
Tue, 23 May, 15:08 |
| Greg Mann |
Re: Review Request 59463: Added test for agent ping timeout during agent recovery. |
Tue, 23 May, 23:59 |
| Benjamin Mahler |
Re: Review Request 59463: Added test for agent ping timeout during agent recovery. |
Wed, 24 May, 01:27 |
| Greg Mann |
Re: Review Request 59463: Added test for agent ping timeout during agent recovery. |
Wed, 24 May, 17:55 |
| Greg Mann |
Re: Review Request 59463: Added test for agent ping timeout during agent recovery. |
Wed, 24 May, 04:30 |
| Greg Mann |
Re: Review Request 59463: Added test for agent ping timeout during agent recovery. |
Wed, 24 May, 17:54 |
| Greg Mann |
Re: Review Request 59463: Added test for agent ping timeout during agent recovery. |
Fri, 26 May, 17:17 |
| Greg Mann |
Re: Review Request 59463: Added test for agent ping timeout during agent recovery. |
Sat, 27 May, 01:32 |
| Greg Mann |
Re: Review Request 59463: Added test for agent ping timeout during agent recovery. |
Tue, 30 May, 23:29 |
| Vinod Kone |
Re: Review Request 59463: Added test for agent ping timeout during agent recovery. |
Tue, 30 May, 23:56 |
| James Peach |
Review Request 59466: Add metrics check to Fetcher tests. |
Mon, 22 May, 21:18 |
| James Peach |
Re: Review Request 59466: Add metrics check to Fetcher tests. |
Mon, 22 May, 21:18 |
| James Peach |
Review Request 59467: Document new Fetcher metrics. |
Mon, 22 May, 21:19 |
| Mesos Reviewbot |
Re: Review Request 59467: Document new Fetcher metrics. |
Tue, 23 May, 03:56 |
| Kapil Arya |
Review Request 59470: Windows: Fixed broken build due to environment secret isolator. |
Mon, 22 May, 23:32 |
| Mesos Reviewbot Windows |
Re: Review Request 59470: Windows: Fixed broken build due to environment secret isolator. |
Mon, 22 May, 23:32 |
| Andrew Schwartzmeyer |
Re: Review Request 59470: Windows: Fixed broken build due to environment secret isolator. |
Tue, 23 May, 16:54 |
| Qian Zhang |
Review Request 59471: Removed `features` field from `Platform` protobuf message. |
Tue, 23 May, 01:09 |
|
Re: Review Request 55331: Added 'OCI' message into 'Image' message. |
|
| Qian Zhang |
Re: Review Request 55331: Added 'OCI' message into 'Image' message. |
Tue, 23 May, 01:14 |
| Qian Zhang |
Re: Review Request 55331: Added 'OCI' message into 'Image' message. |
Wed, 24 May, 09:02 |
|
Re: Review Request 52382: Added stubs for OCI store. |
|
| Qian Zhang |
Re: Review Request 52382: Added stubs for OCI store. |
Tue, 23 May, 01:17 |
| Qian Zhang |
Review Request 59472: Added puller interface for OCI store. |
Tue, 23 May, 01:24 |
| Qian Zhang |
Review Request 59473: Added stubs for prefix puller. |
Tue, 23 May, 01:28 |
| Qian Zhang |
Review Request 59474: Implemented the 'create()' method of puller interface. |
Tue, 23 May, 01:32 |
|
Re: Review Request 54639: Implemented the 'create()' method of OCI store. |
|
| Qian Zhang |
Re: Review Request 54639: Implemented the 'create()' method of OCI store. |
Tue, 23 May, 01:34 |
|
Re: Review Request 56147: Implemented metadata manager for OCI store. |
|
| Qian Zhang |
Re: Review Request 56147: Implemented metadata manager for OCI store. |
Tue, 23 May, 01:38 |
|
Re: Review Request 55333: Implemented the 'get()' and '__get()' methods of OCI store. |
|
| Qian Zhang |
Re: Review Request 55333: Implemented the 'get()' and '__get()' methods of OCI store. |
Tue, 23 May, 01:40 |
|
Re: Review Request 56148: Implemented the '_get()' method of OCI store. |
|
| Qian Zhang |
Re: Review Request 56148: Implemented the '_get()' method of OCI store. |
Tue, 23 May, 01:41 |
|
Re: Review Request 56149: Implemented the 'pull()' method of prefix puller. |
|
| Qian Zhang |
Re: Review Request 56149: Implemented the 'pull()' method of prefix puller. |
Tue, 23 May, 01:42 |
|
Re: Review Request 56150: Implemented the 'fetchIndex()' method of prefix puller. |
|
| Qian Zhang |
Re: Review Request 56150: Implemented the 'fetchIndex()' method of prefix puller. |
Tue, 23 May, 01:43 |
|
Re: Review Request 56152: Implemented the 'fetchManifest()' method of prefix puller. |
|
| Qian Zhang |
Re: Review Request 56152: Implemented the 'fetchManifest()' method of prefix puller. |
Tue, 23 May, 01:45 |
| Neil Conway |
Review Request 59481: Added sorter test for allocation queries about inactive clients. |
Tue, 23 May, 06:26 |
| James Peach |
Re: Review Request 59481: Added sorter test for allocation queries about inactive clients. |
Tue, 23 May, 15:33 |
| Neil Conway |
Re: Review Request 59481: Added sorter test for allocation queries about inactive clients. |
Tue, 23 May, 20:16 |
| Neil Conway |
Re: Review Request 59481: Added sorter test for allocation queries about inactive clients. |
Tue, 23 May, 20:15 |
| Michael Park |
Re: Review Request 59481: Added sorter test for allocation queries about inactive clients. |
Wed, 24 May, 06:05 |
| Neil Conway |
Review Request 59482: Added a new sorter test case, `HierarchicalIterationOrder`. |
Tue, 23 May, 06:26 |
| Neil Conway |
Re: Review Request 59482: Added a new sorter test case, `HierarchicalIterationOrder`. |
Tue, 23 May, 20:15 |
| Michael Park |
Re: Review Request 59482: Added a new sorter test case, `HierarchicalIterationOrder`. |
Wed, 24 May, 06:13 |
| Neil Conway |
Review Request 59483: Replaced the sorter's notion of "activation" with a three-valued enum. |
Tue, 23 May, 06:27 |
| Michael Park |
Re: Review Request 59483: Replaced the sorter's notion of "activation" with a three-valued enum. |
Wed, 24 May, 07:06 |
| Neil Conway |
Review Request 59484: Introduced `DRFSorter::Node::isLeaf()`. |
Tue, 23 May, 06:28 |
| Michael Park |
Re: Review Request 59484: Introduced `DRFSorter::Node::isLeaf()`. |
Wed, 24 May, 07:08 |
| Neil Conway |
Re: Review Request 59484: Introduced `DRFSorter::Node::isLeaf()`. |
Wed, 24 May, 20:28 |
| Michael Park |
Re: Review Request 59484: Introduced `DRFSorter::Node::isLeaf()`. |
Wed, 24 May, 21:00 |
|
Re: Review Request 49571: Added a benchmark test for allocations. |
|
| Anindya Sinha |
Re: Review Request 49571: Added a benchmark test for allocations. |
Tue, 23 May, 18:59 |
| Mesos Reviewbot Windows |
Re: Review Request 49571: Added a benchmark test for allocations. |
Tue, 23 May, 21:39 |
| James Peach |
Re: Review Request 49571: Added a benchmark test for allocations. |
Wed, 24 May, 23:35 |
| Anindya Sinha |
Re: Review Request 49571: Added a benchmark test for allocations. |
Thu, 25 May, 23:30 |
| James Peach |
Re: Review Request 49571: Added a benchmark test for allocations. |
Fri, 26 May, 00:09 |
| Anindya Sinha |
Re: Review Request 49571: Added a benchmark test for allocations. |
Thu, 25 May, 23:30 |
| James Peach |
Re: Review Request 49571: Added a benchmark test for allocations. |
Fri, 26 May, 00:13 |
| Andrew Schwartzmeyer |
Review Request 59500: Added Windows ReviewBot launch script. |
Tue, 23 May, 20:19 |
| Mesos Reviewbot Windows |
Re: Review Request 59500: Added Windows ReviewBot launch script. |
Tue, 23 May, 21:39 |
| Andrew Schwartzmeyer |
Re: Review Request 59500: Added Windows ReviewBot launch script. |
Wed, 24 May, 18:58 |
| Mesos Reviewbot |
Re: Review Request 59500: Added Windows ReviewBot launch script. |
Wed, 24 May, 06:18 |
| Joseph Wu |
Re: Review Request 59500: Added Windows ReviewBot launch script. |
Thu, 25 May, 21:35 |
| Andrew Schwartzmeyer |
Re: Review Request 59500: Added Windows ReviewBot launch script. |
Thu, 25 May, 22:02 |
| Andrew Schwartzmeyer |
Re: Review Request 59500: Added Windows ReviewBot launch script. |
Thu, 25 May, 22:20 |
|
Re: Review Request 53666: Refactor cgroups cleanup to allow cleanup to continue on an error. |
|
| Anindya Sinha |
Re: Review Request 53666: Refactor cgroups cleanup to allow cleanup to continue on an error. |
Tue, 23 May, 20:59 |
| Mesos Reviewbot Windows |
Re: Review Request 53666: Refactor cgroups cleanup to allow cleanup to continue on an error. |
Tue, 23 May, 22:16 |
| Mesos Reviewbot |
Re: Review Request 53666: Refactor cgroups cleanup to allow cleanup to continue on an error. |
Thu, 25 May, 00:37 |
| Anand Mazumdar |
Review Request 59504: Removed an instance of double logging in libprocess. |
Tue, 23 May, 21:57 |
| Benjamin Mahler |
Re: Review Request 59504: Removed an instance of double logging in libprocess. |
Tue, 30 May, 23:25 |
| James Peach |
Review Request 59506: Consistently use EXIT_ERROR in agent startup. |
Tue, 23 May, 22:28 |
| Jiang Yan Xu |
Re: Review Request 59506: Consistently use EXIT() in agent startup. |
Wed, 24 May, 00:21 |
| James Peach |
Re: Review Request 59506: Consistently use EXIT() in agent startup. |
Wed, 24 May, 00:23 |
|
Review Request 59509: Fixed flakiness in MasterAllocatorTest.ResourcesUnused. |
|
| Neil Conway |
Review Request 59509: Fixed flakiness in MasterAllocatorTest.ResourcesUnused. |
Wed, 24 May, 00:28 |
| Mesos Reviewbot |
Re: Review Request 59509: Fixed flakiness in MasterAllocatorTest.ResourcesUnused. |
Wed, 24 May, 14:11 |
| Anand Mazumdar |
Re: Review Request 59509: Fixed flakiness in MasterAllocatorTest.ResourcesUnused. |
Wed, 24 May, 16:42 |
|
Re: Review Request 53842: Add specific metrics for sorting runs across frameworks of a role. |
|
| Anindya Sinha |
Re: Review Request 53842: Add specific metrics for sorting runs across frameworks of a role. |
Wed, 24 May, 04:26 |
| Qian Zhang |
Review Request 59518: Added `StopSignal` field into `Configuration` protobuf message. |
Wed, 24 May, 09:01 |