| Andrew Schwartzmeyer |
Review Request 59155: CMake: Enable `/debug:fastlink` on Windows. |
Wed, 10 May, 20:32 |
| Joseph Wu |
Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows. |
Wed, 10 May, 20:37 |
| Andrew Schwartzmeyer |
Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows. |
Wed, 10 May, 20:54 |
| Andrew Schwartzmeyer |
Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows. |
Wed, 10 May, 20:54 |
| Andrew Schwartzmeyer |
Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows. |
Wed, 10 May, 20:59 |
| Jeff Coffler |
Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows. |
Wed, 10 May, 21:07 |
| Andrew Schwartzmeyer |
Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows. |
Wed, 10 May, 21:14 |
| Jeff Coffler |
Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows. |
Wed, 10 May, 21:08 |
| Li Li |
Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows. |
Thu, 11 May, 04:13 |
| Li Li |
Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows. |
Thu, 11 May, 04:14 |
| Joseph Wu |
Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows. |
Mon, 15 May, 17:16 |
| Andrew Schwartzmeyer |
Review Request 59156: CMake: Use `list(APPEND x ...)` over `set(x ${x} ...)`. |
Wed, 10 May, 20:33 |
| Andrew Schwartzmeyer |
Re: Review Request 59156: CMake: Use `list(APPEND x ...)` over `set(x ${x} ...)`. |
Wed, 10 May, 20:34 |
| Jeff Coffler |
Re: Review Request 59156: CMake: Use `list(APPEND x ...)` over `set(x ${x} ...)`. |
Wed, 10 May, 21:09 |
| Joseph Wu |
Re: Review Request 59156: CMake: Use `list(APPEND x ...)` over `set(x ${x} ...)`. |
Mon, 15 May, 17:16 |
| Andrew Schwartzmeyer |
Review Request 59157: Windows: Fixed toolset handling. |
Wed, 10 May, 20:37 |
| Jeff Coffler |
Re: Review Request 59157: Windows: Fixed toolset handling. |
Wed, 10 May, 21:11 |
| Joseph Wu |
Re: Review Request 59157: Windows: Fixed toolset handling. |
Mon, 15 May, 17:17 |
| Andrew Schwartzmeyer |
Review Request 59116: Windows: Updated `support/windows-build.bat`. |
Wed, 10 May, 20:40 |
| Jeff Coffler |
Re: Review Request 59116: Windows: Updated `support/windows-build.bat`. |
Wed, 10 May, 21:19 |
| Andrew Schwartzmeyer |
Re: Review Request 59116: Windows: Updated `support/windows-build.bat`. |
Wed, 10 May, 21:28 |
| Mesos Reviewbot Windows |
Re: Review Request 59116: Windows: Updated `support/windows-build.bat`. |
Wed, 10 May, 21:21 |
| Andrew Schwartzmeyer |
Re: Review Request 59116: Windows: Updated `support/windows-build.bat`. |
Wed, 10 May, 21:28 |
| Mesos Reviewbot |
Re: Review Request 59116: Windows: Updated `support/windows-build.bat`. |
Thu, 11 May, 02:54 |
| Li Li |
Re: Review Request 59116: Windows: Updated `support/windows-build.bat`. |
Thu, 11 May, 04:19 |
| Joseph Wu |
Re: Review Request 59116: Windows: Updated `support/windows-build.bat`. |
Mon, 15 May, 17:26 |
| Till Toenshoff |
Review Request 59162: Added a clearefying comment to the appc spec.proto. |
Wed, 10 May, 23:19 |
| Joseph Wu |
Review Request 59164: Updated fetcher tests to reflect changed interfaces. |
Thu, 11 May, 00:27 |
| Jie Yu |
Re: Review Request 59164: Updated fetcher tests to reflect changed interfaces. |
Thu, 11 May, 15:59 |
|
Re: Review Request 55903: Update XFS disk isolator documentation. |
|
| Jiang Yan Xu |
Re: Review Request 55903: Update XFS disk isolator documentation. |
Thu, 11 May, 01:12 |
| James Peach |
Re: Review Request 55903: Update XFS disk isolator documentation. |
Thu, 11 May, 17:55 |
| Jiang Yan Xu |
Re: Review Request 55903: Update XFS disk isolator documentation. |
Thu, 11 May, 18:17 |
| James Peach |
Re: Review Request 55903: Update XFS disk isolator documentation. |
Thu, 11 May, 18:20 |
| Mesos Reviewbot |
Re: Review Request 55903: Update XFS disk isolator documentation. |
Fri, 12 May, 02:07 |
|
Re: Review Request 56680: Use the EXIT() macro more consistently in agent startup. |
|
| Jiang Yan Xu |
Re: Review Request 56680: Use the EXIT() macro more consistently in agent startup. |
Thu, 11 May, 08:29 |
| James Peach |
Re: Review Request 56680: Use the EXIT() macro more consistently in agent startup. |
Thu, 11 May, 17:36 |
| Armand Grillet |
Review Request 59177: CLI: Added Config class to manage the config file. |
Thu, 11 May, 13:23 |
| Mesos Reviewbot |
Re: Review Request 59177: CLI: Added Config class to manage the config file. |
Thu, 11 May, 18:09 |
| Armand Grillet |
Re: Review Request 59177: CLI: Added Config class to manage the config file. |
Mon, 15 May, 01:59 |
| Mesos Reviewbot |
Re: Review Request 59177: CLI: Added Config class to manage the config file. |
Mon, 15 May, 03:59 |
| Armand Grillet |
Re: Review Request 59177: CLI: Added Config class to manage the config file. |
Mon, 29 May, 12:36 |
| Kevin Klues |
Re: Review Request 59177: CLI: Added Config class to manage the config file. |
Mon, 29 May, 12:37 |
|
Review Request 59183: Refactor setting capabilities into a helper function. |
|
| James Peach |
Review Request 59183: Refactor setting capabilities into a helper function. |
Thu, 11 May, 16:43 |
| Jie Yu |
Re: Review Request 59183: Refactor setting capabilities into a helper function. |
Wed, 17 May, 22:11 |
| James Peach |
Review Request 59184: Add support for explicitly setting bounding capabilities. |
Thu, 11 May, 16:44 |
| James Peach |
Review Request 59185: Add ambient capability support. |
Thu, 11 May, 16:44 |
| James Peach |
Re: Review Request 59185: Add ambient capability support. |
Thu, 11 May, 16:45 |
| James Peach |
Re: Review Request 59185: Add ambient capability support. |
Wed, 24 May, 23:46 |
| James Peach |
Review Request 59186: Additional linux/capabilities isolator documention. |
Thu, 11 May, 16:45 |
| James Peach |
Re: Review Request 59186: Additional linux/capabilities isolator documentation. |
Wed, 24 May, 23:46 |
| Mesos Reviewbot Windows |
Re: Review Request 59186: Additional linux/capabilities isolator documentation. |
Thu, 25 May, 23:13 |
| Neil Conway |
Review Request 59190: Adjusted test expectation for change to stout's Version. |
Thu, 11 May, 17:30 |
| Benjamin Mahler |
Re: Review Request 59190: Adjusted test expectation for change to stout's Version. |
Thu, 11 May, 18:51 |
| Neil Conway |
Review Request 59191: Added another test case for Docker version parsing. |
Thu, 11 May, 17:30 |
| Benjamin Mahler |
Re: Review Request 59191: Added another test case for Docker version parsing. |
Thu, 11 May, 18:52 |
|
Re: Review Request 58487: Fix allocation quantities when shared resources are removed. |
|
| Anindya Sinha |
Re: Review Request 58487: Fix allocation quantities when shared resources are removed. |
Thu, 11 May, 18:13 |
| Neil Conway |
Review Request 59198: Added CHANGELOG note that 1.3.0 and 1.2.1 masters ignore old agents. |
Thu, 11 May, 18:48 |
| Neil Conway |
Re: Review Request 59198: Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register. |
Thu, 11 May, 18:58 |
| Adam B |
Re: Review Request 59198: Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register. |
Thu, 11 May, 19:01 |
| Neil Conway |
Re: Review Request 59198: Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register. |
Thu, 11 May, 19:47 |
| Adam B |
Re: Review Request 59198: Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register. |
Thu, 11 May, 20:25 |
| Neil Conway |
Re: Review Request 59198: Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register. |
Thu, 11 May, 21:10 |
| Adam B |
Re: Review Request 59198: Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register. |
Thu, 11 May, 21:20 |
| Jeff Coffler |
Review Request 59203: Enable NetTest.LinkDevice and NetTest.Mac tests on Windows platform. |
Thu, 11 May, 20:05 |
| Jeff Coffler |
Re: Review Request 59203: Enable NetTest.LinkDevice and NetTest.Mac tests on Windows platform. |
Thu, 11 May, 20:09 |
| Andrew Schwartzmeyer |
Re: Review Request 59203: Enable NetTest.LinkDevice and NetTest.Mac tests on Windows platform. |
Tue, 16 May, 18:19 |
|
Review Request 59200: Ported the net::links routine to Windows platform. |
|
| Jeff Coffler |
Review Request 59200: Ported the net::links routine to Windows platform. |
Thu, 11 May, 20:12 |
| Jeff Coffler |
Re: Review Request 59200: Ported the net::links routine to Windows platform. |
Thu, 11 May, 20:41 |
| Jeff Coffler |
Re: Review Request 59200: Ported the net::links routine to Windows platform. |
Thu, 11 May, 20:56 |
| Jeff Coffler |
Review Request 59201: Ported the IPNetwork::fromLinkDevice to the Windows Platform. |
Thu, 11 May, 20:14 |
| Jeff Coffler |
Review Request 59202: Ported the net::mac to the Windows Platform. |
Thu, 11 May, 20:15 |
| Jeff Coffler |
Re: Review Request 59202: Ported the net::mac to the Windows Platform. |
Thu, 11 May, 21:10 |
| Anindya Sinha |
Review Request 59194: Validate DESTROY operation in `Resources::apply()`. |
Thu, 11 May, 20:21 |
| Jiang Yan Xu |
Re: Review Request 59194: Validate DESTROY operation in `Resources::apply()`. |
Fri, 12 May, 18:19 |
| Anindya Sinha |
Re: Review Request 59194: Validate DESTROY operation in `Resources::apply()`. |
Sat, 13 May, 04:50 |
| Anindya Sinha |
Re: Review Request 59194: Validate DESTROY operation in `Resources::apply()`. |
Sat, 13 May, 04:50 |
| Jiang Yan Xu |
Re: Review Request 59194: Validate DESTROY operation in `Resources::apply()`. |
Mon, 15 May, 05:41 |
| Anindya Sinha |
Re: Review Request 59194: Validate DESTROY operation in `Resources::apply()`. |
Mon, 15 May, 18:01 |
| Anindya Sinha |
Re: Review Request 59194: Validate DESTROY operation in `Resources::apply()`. |
Mon, 15 May, 18:01 |
| Jiang Yan Xu |
Re: Review Request 59194: Validate DESTROY operation in `Resources::apply()`. |
Mon, 15 May, 21:59 |
| Anindya Sinha |
Review Request 59195: Ensure that allocator can be updated before committing changes. |
Thu, 11 May, 20:21 |
| Anindya Sinha |
Re: Review Request 59195: Ensure that allocator can be updated before committing changes. |
Sat, 13 May, 04:51 |
| Anindya Sinha |
Re: Review Request 59195: Ensure that allocator can be updated before committing changes. |
Mon, 15 May, 18:01 |
| Anindya Sinha |
Re: Review Request 59195: Ensure that allocator can be updated before committing changes. |
Wed, 17 May, 02:00 |
|
Re: Review Request 58486: Update the allocator on a per offer operation. |
|
| Anindya Sinha |
Re: Review Request 58486: Update the allocator on a per offer operation. |
Thu, 11 May, 20:21 |
| Mesos Reviewbot |
Re: Review Request 58486: Update the allocator on a per offer operation. |
Fri, 12 May, 12:27 |
| Anindya Sinha |
Re: Review Request 58486: Update the allocator on a per offer operation. |
Sat, 13 May, 04:51 |
| Mesos Reviewbot |
Re: Review Request 58486: Update the allocator on a per offer operation. |
Sat, 13 May, 10:19 |
| Anindya Sinha |
Re: Review Request 58486: Update the allocator on a per offer operation. |
Mon, 15 May, 18:01 |
| Mesos Reviewbot |
Re: Review Request 58486: Update the allocator on a per offer operation. |
Tue, 16 May, 01:38 |
| Anindya Sinha |
Re: Review Request 58486: Update the allocator on a per offer operation. |
Wed, 17 May, 02:00 |
| Mesos Reviewbot |
Re: Review Request 58486: Update the allocator on a per offer operation. |
Wed, 17 May, 10:35 |
| Anindya Sinha |
Re: Review Request 58486: Update the allocator on a per offer operation. |
Wed, 17 May, 16:50 |
| Mesos Reviewbot |
Re: Review Request 58486: Update the allocator on a per offer operation. |
Wed, 17 May, 18:24 |
| Anindya Sinha |
Re: Review Request 58486: Update the allocator on a per offer operation. |
Thu, 11 May, 20:21 |
|
Re: Review Request 57935: Recalculate shares only when total scalar quantities have changed. |
|
| Anindya Sinha |
Re: Review Request 57935: Recalculate shares only when total scalar quantities have changed. |
Thu, 11 May, 21:02 |
| Mesos Reviewbot |
Re: Review Request 57935: Recalculate shares only when total scalar quantities have changed. |
Fri, 12 May, 14:54 |
|
Re: Review Request 58347: Introduced a filter for test cases that need thread-safety. |
|
| Neil Conway |
Re: Review Request 58347: Introduced a filter for test cases that need thread-safety. |
Thu, 11 May, 21:36 |
| Neil Conway |
Re: Review Request 58347: Introduced a filter for test cases that need thread-safety. |
Thu, 11 May, 21:41 |
| Jan Schlicht |
Re: Review Request 58347: Introduced a filter for test cases that need thread-safety. |
Mon, 15 May, 10:24 |
| Jan Schlicht |
Re: Review Request 58347: Introduced a filter for test cases that need thread-safety. |
Mon, 15 May, 10:25 |
| Neil Conway |
Re: Review Request 58347: Introduced a filter for test cases that need thread-safety. |
Tue, 16 May, 23:36 |
| Neil Conway |
Review Request 59213: Cleaned up agent re-registration code in the master slightly. |
Thu, 11 May, 23:31 |
| Benjamin Mahler |
Re: Review Request 59213: Cleaned up agent re-registration code in the master slightly. |
Fri, 12 May, 20:27 |
| Neil Conway |
Review Request 59214: Removed code for handling missing FrameworkInfo of a running task. |
Thu, 11 May, 23:31 |
| Benjamin Mahler |
Re: Review Request 59214: Removed code for handling missing FrameworkInfo of a running task. |
Fri, 12 May, 21:36 |
| Neil Conway |
Re: Review Request 59214: Removed code for handling missing FrameworkInfo of a running task. |
Tue, 16 May, 20:02 |
| Neil Conway |
Re: Review Request 59214: Removed code for handling missing FrameworkInfo of a running task. |
Mon, 15 May, 23:13 |
| Neil Conway |
Review Request 59215: Removed orphaned tasks from webui. |
Thu, 11 May, 23:32 |
| Benjamin Mahler |
Re: Review Request 59215: Removed orphaned tasks from webui. |
Fri, 12 May, 21:37 |
| Neil Conway |
Review Request 59216: Fixed some inaccurate comments. |
Thu, 11 May, 23:32 |
| Benjamin Mahler |
Re: Review Request 59216: Fixed some inaccurate comments. |
Fri, 12 May, 21:37 |
| Neil Conway |
Re: Review Request 59216: Fixed some inaccurate comments. |
Mon, 15 May, 23:18 |
| Neil Conway |
Re: Review Request 59216: Fixed some inaccurate comments. |
Mon, 15 May, 23:19 |
| Neil Conway |
Re: Review Request 59216: Fixed some inaccurate comments. |
Mon, 15 May, 23:16 |
| Neil Conway |
Review Request 59217: Removed outdated comments. |
Thu, 11 May, 23:32 |
| Benjamin Mahler |
Re: Review Request 59217: Removed outdated comments. |
Fri, 12 May, 21:38 |
| Neil Conway |
Review Request 59218: Removed code for old agents when handling status updates. |
Thu, 11 May, 23:32 |
| Benjamin Mahler |
Re: Review Request 59218: Removed code for old agents when handling status updates. |
Fri, 12 May, 21:38 |
| Neil Conway |
Review Request 59219: Removed code for old agents in agent re-registration logic. |
Thu, 11 May, 23:32 |
| Mesos Reviewbot |
Re: Review Request 59219: Removed code for old agents in agent re-registration logic. |
Fri, 12 May, 18:58 |
| Benjamin Mahler |
Re: Review Request 59219: Removed code for old agents in agent re-registration logic. |
Fri, 12 May, 21:40 |
| Neil Conway |
Re: Review Request 59219: Removed code for old agents in agent re-registration logic. |
Tue, 16 May, 20:31 |
| Neil Conway |
Re: Review Request 59219: Removed logic for handling missing FrameworkID in ExecutorInfo. |
Tue, 16 May, 20:36 |
| Benjamin Mahler |
Re: Review Request 59219: Removed logic for handling missing FrameworkID in ExecutorInfo. |
Tue, 30 May, 23:39 |
| Neil Conway |
Re: Review Request 59219: Removed logic for handling missing FrameworkID in ExecutorInfo. |
Wed, 31 May, 18:27 |
| Neil Conway |
Review Request 59243: Added missing `constexpr` to Days constructors in stout. |
Fri, 12 May, 20:46 |
| Benjamin Bannier |
Re: Review Request 59243: Added missing `constexpr` to Days constructors in stout. |
Fri, 12 May, 21:08 |
| Avinash sridharan |
Review Request 59233: Updated v6 address for containers running on host network. |
Fri, 12 May, 22:22 |
| Mesos Reviewbot |
Re: Review Request 59233: Updated v6 address for containers running on host network. |
Sat, 13 May, 06:48 |
| Benjamin Hindman |
Re: Review Request 59233: Updated v6 address for containers running on host network. |
Fri, 26 May, 00:15 |
| Avinash sridharan |
Re: Review Request 59233: Updated v6 address for containers running on host network. |
Wed, 31 May, 18:38 |
| Mesos Reviewbot Windows |
Re: Review Request 59233: Updated v6 address for containers running on host network. |
Wed, 31 May, 20:47 |
| Alexander Rukletsov |
Review Request 59248: Fixed a fd-related build on Windows. |
Fri, 12 May, 22:43 |
| Jeff Coffler |
Re: Review Request 59248: Fixed a fd-related build on Windows. |
Fri, 12 May, 23:10 |
| Alexander Rukletsov |
Re: Review Request 59248: Fixed a fd-related build on Windows. |
Fri, 12 May, 23:13 |
| Alexander Rukletsov |
Re: Review Request 59248: Fixed a fd-related build on Windows. |
Fri, 12 May, 23:13 |
| Jiang Yan Xu |
Review Request 59254: Used loop to implement allocator interval-based allocation. |
Sat, 13 May, 06:06 |
| Mesos Reviewbot |
Re: Review Request 59254: Used loop to implement allocator interval-based allocation. |
Sat, 13 May, 12:13 |
| Jiang Yan Xu |
Re: Review Request 59254: Used loop to implement allocator interval-based allocation. |
Tue, 30 May, 18:12 |
| Benjamin Mahler |
Re: Review Request 59254: Used loop to implement allocator interval-based allocation. |
Tue, 30 May, 20:55 |
| Jiang Yan Xu |
Re: Review Request 59254: Used loop to implement allocator interval-based allocation. |
Tue, 30 May, 20:59 |
|
Re: Review Request 53840: Metric in the allocator to track latency in running allocations. |
|
| Jiang Yan Xu |
Re: Review Request 53840: Metric in the allocator to track latency in running allocations. |
Mon, 15 May, 05:25 |
| Anindya Sinha |
Re: Review Request 53840: Metric in the allocator to track latency in running allocations. |
Tue, 16 May, 06:23 |
| Jiang Yan Xu |
Re: Review Request 53840: Metric in the allocator to track latency in running allocations. |
Mon, 15 May, 05:27 |
| Anindya Sinha |
Re: Review Request 53840: Metric in the allocator to track latency in running allocations. |
Tue, 16 May, 06:23 |
| Anindya Sinha |
Re: Review Request 53840: Metric in the allocator to track latency in running allocations. |
Tue, 16 May, 07:22 |
| Anindya Sinha |
Re: Review Request 53840: Metric in the allocator to track latency in running allocations. |
Tue, 23 May, 16:30 |
| Jiang Yan Xu |
Re: Review Request 53840: Metric in the allocator to track latency in running allocations. |
Tue, 23 May, 23:56 |
| Anindya Sinha |
Re: Review Request 53840: Metric in the allocator to track latency in running allocations. |
Tue, 16 May, 06:23 |
|
Re: Review Request 58348: Fixed use of 'GTEST_IS_THREADSAFE'. |
|
| Jan Schlicht |
Re: Review Request 58348: Fixed use of 'GTEST_IS_THREADSAFE'. |
Mon, 15 May, 10:24 |
| Neil Conway |
Re: Review Request 58348: Fixed use of 'GTEST_IS_THREADSAFE'. |
Tue, 16 May, 23:36 |
|
Re: Review Request 58349: Updated GMock/GTest to version 1.8.0. |
|
| Jan Schlicht |
Re: Review Request 58349: Updated GMock/GTest to version 1.8.0. |
Mon, 15 May, 10:27 |
| Jan Schlicht |
Re: Review Request 58349: Updated GMock/GTest to version 1.8.0. |
Mon, 15 May, 10:28 |
| Jan Schlicht |
Re: Review Request 58349: Updated GMock/GTest to version 1.8.0. |
Mon, 15 May, 12:05 |
| Neil Conway |
Re: Review Request 58349: Updated GMock/GTest to version 1.8.0. |
Tue, 16 May, 23:35 |
| Jan Schlicht |
Re: Review Request 58349: Updated GMock/GTest to version 1.8.0. |
Wed, 17 May, 10:01 |
| Jan Schlicht |
Re: Review Request 58349: Updated GMock/GTest to version 1.8.0. |
Wed, 17 May, 10:00 |
| Neil Conway |
Re: Review Request 58349: Updated GMock/GTest to version 1.8.0. |
Wed, 17 May, 17:49 |