From reviews-return-61378-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed May 31 21:29:46 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1970D18BF3 for ; Wed, 31 May 2017 21:29:46 +0000 (UTC) Received: (qmail 51708 invoked by uid 500); 31 May 2017 21:29:46 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 51694 invoked by uid 500); 31 May 2017 21:29:46 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 51682 invoked by uid 99); 31 May 2017 21:29:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 May 2017 21:29:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 55A33C0716; Wed, 31 May 2017 21:29:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id scKIH-usxbCf; Wed, 31 May 2017 21:29:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6A06A5F295; Wed, 31 May 2017 21:29:44 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 15114E01D9; Wed, 31 May 2017 21:29:44 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id D8F80C40102; Wed, 31 May 2017 21:29:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8526199198400379130==" MIME-Version: 1.0 Subject: Re: Review Request 59551: Change launcher working directory before dropping privilege. From: Jie Yu To: Jie Yu , Jiang Yan Xu Cc: James Peach , mesos Date: Wed, 31 May 2017 21:29:43 -0000 Message-ID: <20170531212943.8718.55297@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59551/ X-Sender: Jie Yu X-ReviewBoard-ShipIt: 1 References: <20170524234555.1142.42318@reviews-vm2.apache.org> In-Reply-To: <20170524234555.1142.42318@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Jie Yu X-ReviewRequest-Repository: mesos --===============8526199198400379130== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59551/#review176527 ----------------------------------------------------------- Ship it! Ship It! - Jie Yu On May 24, 2017, 11:45 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59551/ > ----------------------------------------------------------- > > (Updated May 24, 2017, 11:45 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-7476 > https://issues.apache.org/jira/browse/MESOS-7476 > > > Repository: mesos > > > Description > ------- > > The launcher needs to change its working directory before dropping > privilege by switching users and installing capabilities, because > afterwards it might not have access to traverse to the desired > working directory. > > > Diffs > ----- > > src/slave/containerizer/mesos/launch.cpp f48d294a0a832dfe248c4a83849ee5a63cb76bce > > > Diff: https://reviews.apache.org/r/59551/diff/1/ > > > Testing > ------- > > make check (Fedora 25) > > > Thanks, > > James Peach > > --===============8526199198400379130==--