From reviews-return-60885-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue May 23 01:04:10 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D4F8119605 for ; Tue, 23 May 2017 01:04:10 +0000 (UTC) Received: (qmail 87922 invoked by uid 500); 23 May 2017 01:04:10 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 87883 invoked by uid 500); 23 May 2017 01:04:10 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 87872 invoked by uid 99); 23 May 2017 01:04:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 May 2017 01:04:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id DFD22190A20; Tue, 23 May 2017 01:04:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 9LlGA6PCl392; Tue, 23 May 2017 01:04:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3274A5FB32; Tue, 23 May 2017 01:04:08 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DBCC9E01D9; Tue, 23 May 2017 01:04:07 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id B0C00C40485; Tue, 23 May 2017 01:04:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8173695727974818790==" MIME-Version: 1.0 Subject: Re: Review Request 59464: Add Fetcher total and success metrics. From: Joseph Wu To: Mesos Reviewbot Cc: mesos , James Peach , Joseph Wu Date: Tue, 23 May 2017 01:04:07 -0000 Message-ID: <20170523010407.58536.1853@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joseph Wu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59464/ X-Sender: Joseph Wu References: <20170522211550.58535.52280@reviews-vm2.apache.org> In-Reply-To: <20170522211550.58535.52280@reviews-vm2.apache.org> Reply-To: Joseph Wu X-ReviewRequest-Repository: mesos --===============8173695727974818790== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59464/#review175740 ----------------------------------------------------------- What do you think about making fetch failures a sub-metric of `container_launch_errors`? The fetcher is only called during container launch. If fetching fails, container launch will also fail (and increment this counter). It might be useful to separate out fetch failures from other types of launch failures. This approach might be a bit more work to do so, since the parent metric lives inside the Agent, rather than the Fetcher process. - Joseph Wu On May 22, 2017, 2:15 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59464/ > ----------------------------------------------------------- > > (Updated May 22, 2017, 2:15 p.m.) > > > Review request for mesos and Mesos Reviewbot. > > > Bugs: MESOS-7524 > https://issues.apache.org/jira/browse/MESOS-7524 > > > Repository: mesos > > > Description > ------- > > Add the Fetcher metrics to track the number of fetch requests sent to > the Fetcher (`containerizer/fetcher/total`) and the number of errors > reported by the Fetcher (`containerizer/fetcher/errors`). > > > Diffs > ----- > > src/slave/containerizer/fetcher.hpp 9e3018dc087ed55c61b2824d0105bc5339b83043 > src/slave/containerizer/fetcher.cpp a910fea5a5556afb376524c5bb2ff98d7d84e611 > > > Diff: https://reviews.apache.org/r/59464/diff/2/ > > > Testing > ------- > > make check (Fedora 25) > > > Thanks, > > James Peach > > --===============8173695727974818790==--