From reviews-return-60736-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed May 17 22:14:01 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F08CE19D03 for ; Wed, 17 May 2017 22:14:01 +0000 (UTC) Received: (qmail 28258 invoked by uid 500); 17 May 2017 22:14:01 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 28227 invoked by uid 500); 17 May 2017 22:14:01 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 28216 invoked by uid 99); 17 May 2017 22:14:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 May 2017 22:14:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3F4B6C0D8B; Wed, 17 May 2017 22:14:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.001 X-Spam-Level: *** X-Spam-Status: No, score=3.001 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ob_mpjELtuhi; Wed, 17 May 2017 22:14:00 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 198E95F568; Wed, 17 May 2017 22:14:00 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CCA28E01A8; Wed, 17 May 2017 22:13:59 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 8B374C40390; Wed, 17 May 2017 22:13:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2513372600790804187==" MIME-Version: 1.0 Subject: Re: Review Request 59293: Windows: Fixed apply-reviews.py to retain line feeds. From: Andrew Schwartzmeyer To: Joseph Wu Cc: Mesos Reviewbot , mesos Date: Wed, 17 May 2017 22:13:59 -0000 Message-ID: <20170517221359.55002.16365@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrew Schwartzmeyer X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59293/ X-Sender: Andrew Schwartzmeyer References: <20170515204545.37593.56733@reviews-vm2.apache.org> In-Reply-To: <20170515204545.37593.56733@reviews-vm2.apache.org> Reply-To: Andrew Schwartzmeyer X-ReviewRequest-Repository: mesos --===============2513372600790804187== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59293/ ----------------------------------------------------------- (Updated May 17, 2017, 10:13 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-7343 https://issues.apache.org/jira/browse/MESOS-7343 Repository: mesos Description ------- Write using 'wb' instead of 'w' for binary mode. This writes the downloaded patch file exactly as it came, instead of treating as text and changing line endings. This resolves a bug where `git apply` doesn't always work with CRLF endings in patch files. Diffs ----- support/apply-reviews.py b495675de80fd995f208f1b9ca8c88a717cf2850 Diff: https://reviews.apache.org/r/59293/diff/1/ Testing ------- Applied patch 59177 successfully after failing to apply it without change due to: ``` 59177.patch:9: trailing whitespace. 59177.patch:18: trailing whitespace. def autocomplete(cmds, plugins, config, argv): 59177.patch:26: trailing whitespace. current_word = argv[0] 59177.patch:27: trailing whitespace. argv = argv[1:] 59177.patch:36: trailing whitespace. return plugin_class(settings, config).__autocomplete_base__( error: git apply: bad git-diff - expected /dev/null on line 167 ``` Thanks, Andrew Schwartzmeyer --===============2513372600790804187==--