From reviews-return-60658-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue May 16 19:25:49 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8C11819431 for ; Tue, 16 May 2017 19:25:49 +0000 (UTC) Received: (qmail 82717 invoked by uid 500); 16 May 2017 19:25:49 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 82627 invoked by uid 500); 16 May 2017 19:25:47 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 82612 invoked by uid 99); 16 May 2017 19:25:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 May 2017 19:25:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4B3A7C6AA7; Tue, 16 May 2017 19:25:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id V7nxa-JdBbEZ; Tue, 16 May 2017 19:25:45 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id F388F5FBC1; Tue, 16 May 2017 19:25:44 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8C830E01A8; Tue, 16 May 2017 19:25:44 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 8178AC40155; Tue, 16 May 2017 19:25:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4939166308709567987==" MIME-Version: 1.0 Subject: Re: Review Request 59000: Added environment secret isolator. From: Kapil Arya To: Jie Yu , Vinod Kone , Gilbert Song , Greg Mann Cc: Chun-Hung Hsiao , mesos Date: Tue, 16 May 2017 19:25:44 -0000 Message-ID: <20170516192544.61684.96051@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Kapil Arya X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59000/ X-Sender: Kapil Arya References: <20170515134236.55747.57313@reviews-vm2.apache.org> In-Reply-To: <20170515134236.55747.57313@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/environment_secret.cpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/environment_secret.hpp X-ReviewBoard-Diff-For: src/tests/containerizer/environment_secret_isolator_tests.cpp Reply-To: Kapil Arya X-ReviewRequest-Repository: mesos --===============4939166308709567987== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On May 15, 2017, 9:42 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/environment_secret.cpp > > Lines 137-138 (patched) > > > > > > How about custom executor/default executor? `task_environment` is for command task specific. We already set the `launchInfo.environment`; are you suggesting to not set task_environment? - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59000/#review174942 ----------------------------------------------------------- On May 16, 2017, 3:22 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59000/ > ----------------------------------------------------------- > > (Updated May 16, 2017, 3:22 p.m.) > > > Review request for mesos, Gilbert Song, Greg Mann, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added environment secret isolator. > > > Diffs > ----- > > src/CMakeLists.txt eef718d95b5d8e051a5094369dc9b4532bc307ff > src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a > src/launcher/executor.cpp b05f73e539c22d4d40f07df76168a06373b818d4 > src/slave/containerizer/mesos/containerizer.cpp 97837c83cc223950750e4cd088f4da067023c96c > src/slave/containerizer/mesos/isolators/environment_secret.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/environment_secret.cpp PRE-CREATION > src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328 > src/tests/containerizer/environment_secret_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/59000/diff/7/ > > > Testing > ------- > > Added a new test and ran `make check`. > > > Thanks, > > Kapil Arya > > --===============4939166308709567987==--