From reviews-return-60586-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon May 15 13:42:40 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3DD00185E7 for ; Mon, 15 May 2017 13:42:40 +0000 (UTC) Received: (qmail 30828 invoked by uid 500); 15 May 2017 13:42:40 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 30798 invoked by uid 500); 15 May 2017 13:42:40 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 30784 invoked by uid 99); 15 May 2017 13:42:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 May 2017 13:42:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6522018138F; Mon, 15 May 2017 13:42:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.701 X-Spam-Level: **** X-Spam-Status: No, score=4.701 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id dbYSAZiRyY1N; Mon, 15 May 2017 13:42:37 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 2E1EB5FC1C; Mon, 15 May 2017 13:42:37 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BF153E01A8; Mon, 15 May 2017 13:42:36 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 99CF4C402D5; Mon, 15 May 2017 13:42:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0184108594480889155==" MIME-Version: 1.0 Subject: Re: Review Request 59000: Added environment secret isolator. From: Gilbert Song To: Jie Yu , Vinod Kone , Gilbert Song , Greg Mann Cc: Kapil Arya , Chun-Hung Hsiao , mesos Date: Mon, 15 May 2017 13:42:36 -0000 Message-ID: <20170515134236.55747.57313@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gilbert Song X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59000/ X-Sender: Gilbert Song References: <20170512175255.50464.31444@reviews-vm2.apache.org> In-Reply-To: <20170512175255.50464.31444@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/environment_secret.cpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/environment_secret.hpp X-ReviewBoard-Diff-For: src/tests/containerizer/environment_secret_isolator_tests.cpp Reply-To: Gilbert Song X-ReviewRequest-Repository: mesos --===============0184108594480889155== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59000/#review174942 ----------------------------------------------------------- src/slave/containerizer/mesos/isolators/environment_secret.hpp Lines 43-45 (patched) No need recover(). src/slave/containerizer/mesos/isolators/environment_secret.cpp Lines 77-82 (patched) Ditto. src/slave/containerizer/mesos/isolators/environment_secret.cpp Lines 98-101 (patched) I would move this part above `secretResolver->resolve()`. src/slave/containerizer/mesos/isolators/environment_secret.cpp Lines 99-100 (patched) Let's log the `Environment::Variable::name`. src/slave/containerizer/mesos/isolators/environment_secret.cpp Lines 103 (patched) this is a bug? should check `variable.has_secret()` first? src/slave/containerizer/mesos/isolators/environment_secret.cpp Lines 137-138 (patched) How about custom executor/default executor? `task_environment` is for command task specific. src/tests/containerizer/environment_secret_isolator_tests.cpp Lines 50 (patched) s/FetchSecret/ResolveSecret/g ? src/tests/containerizer/environment_secret_isolator_tests.cpp Lines 86-91 (patched) use the helper from test/mesos.hpp `createTask()`. src/tests/containerizer/environment_secret_isolator_tests.cpp Lines 95-97 (patched) Could we use of `strings::format()` to make this part more readable? src/tests/containerizer/environment_secret_isolator_tests.cpp Lines 100-107 (patched) Let's add a `TODO` here to refactor the helper `createEnvironment()` to support value based/secret based env var respectively. - Gilbert Song On May 12, 2017, 10:52 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59000/ > ----------------------------------------------------------- > > (Updated May 12, 2017, 10:52 a.m.) > > > Review request for mesos, Gilbert Song, Greg Mann, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added environment secret isolator. > > > Diffs > ----- > > src/CMakeLists.txt 40d921ee7026f5ac47efbf0243e1cafab57825f9 > src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a > src/launcher/executor.cpp b05f73e539c22d4d40f07df76168a06373b818d4 > src/slave/containerizer/mesos/containerizer.cpp 97837c83cc223950750e4cd088f4da067023c96c > src/slave/containerizer/mesos/isolators/environment_secret.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/environment_secret.cpp PRE-CREATION > src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328 > src/tests/containerizer/environment_secret_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/59000/diff/6/ > > > Testing > ------- > > Added a new test and ran `make check`. > > > Thanks, > > Kapil Arya > > --===============0184108594480889155==--