From reviews-return-60524-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri May 12 12:27:49 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3595818E1F for ; Fri, 12 May 2017 12:27:49 +0000 (UTC) Received: (qmail 43931 invoked by uid 500); 12 May 2017 12:27:49 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 43911 invoked by uid 500); 12 May 2017 12:27:49 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 43900 invoked by uid 99); 12 May 2017 12:27:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 May 2017 12:27:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 70D6E18055C; Fri, 12 May 2017 12:27:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id SMuUltYGYO-p; Fri, 12 May 2017 12:27:47 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E34985F398; Fri, 12 May 2017 12:27:46 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 871A2E0059; Fri, 12 May 2017 12:27:46 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 5FC06C40099; Fri, 12 May 2017 12:27:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2943093569080044710==" MIME-Version: 1.0 Subject: Re: Review Request 58486: Update the allocator on a per offer operation. From: Mesos Reviewbot To: James Peach , Jiang Yan Xu Cc: Mesos Reviewbot , Anindya Sinha , mesos Date: Fri, 12 May 2017 12:27:46 -0000 Message-ID: <20170512122746.42669.8721@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58486/ X-Sender: Mesos Reviewbot References: <20170511202144.42669.78095@reviews-vm2.apache.org> In-Reply-To: <20170511202144.42669.78095@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============2943093569080044710== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58486/#review174780 ----------------------------------------------------------- Patch looks great! Reviews applied: [59194, 59195, 58486] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 11, 2017, 8:21 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58486/ > ----------------------------------------------------------- > > (Updated May 11, 2017, 8:21 p.m.) > > > Review request for mesos, James Peach and Jiang Yan Xu. > > > Bugs: MESOS-7308 > https://issues.apache.org/jira/browse/MESOS-7308 > > > Repository: mesos > > > Description > ------- > > The allocator is updated for each offer operation in the order specified > in the `ACCEPT` call. Once the allocator is updated successfully, we > handle subsequent operations as follows: > > 1) Launch or Launch Group: We launch the tasks or task group on the > agent. > 2) (Un)reservation or Create/Destroy of Persistent Volumes: We send > the `CheckPointResourcesMessage` to the agent. > > If allocation for any of the operations fail, those resources are not > recovered from the allocator. > > > Diffs > ----- > > src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732 > src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad > > > Diff: https://reviews.apache.org/r/58486/diff/4/ > > > Testing > ------- > > Tests passed. > > > Thanks, > > Anindya Sinha > > --===============2943093569080044710==--