From reviews-return-60440-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu May 11 07:53:38 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 84F70192F9 for ; Thu, 11 May 2017 07:53:36 +0000 (UTC) Received: (qmail 63913 invoked by uid 500); 11 May 2017 07:53:36 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 63882 invoked by uid 500); 11 May 2017 07:53:36 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 63871 invoked by uid 99); 11 May 2017 07:53:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 May 2017 07:53:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 85E79C134E; Thu, 11 May 2017 07:53:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.451 X-Spam-Level: **** X-Spam-Status: No, score=4.451 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id qeNPnX_qSYuC; Thu, 11 May 2017 07:53:34 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 77F525FC99; Thu, 11 May 2017 07:53:34 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2451CE01A8; Thu, 11 May 2017 07:53:34 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id C2296C40295; Thu, 11 May 2017 07:53:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3121121160766152685==" MIME-Version: 1.0 Subject: Re: Review Request 59001: Added volume secret isolator. From: Jie Yu To: Jie Yu , Vinod Kone , Gilbert Song Cc: Kapil Arya , Chun-Hung Hsiao , mesos Date: Thu, 11 May 2017 07:53:33 -0000 Message-ID: <20170511075333.27864.53078@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59001/ X-Sender: Jie Yu References: <20170509181135.17093.73044@reviews-vm2.apache.org> In-Reply-To: <20170509181135.17093.73044@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/tests/containerizer/volume_secret_isolator_tests.cpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/secret.cpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/secret.hpp Reply-To: Jie Yu X-ReviewRequest-Repository: mesos --===============3121121160766152685== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59001/#review174610 ----------------------------------------------------------- src/slave/containerizer/mesos/isolators/volume/secret.cpp Lines 149 (patched) Can you do `-n` to avoid changing mtab? - Jie Yu On May 9, 2017, 6:11 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59001/ > ----------------------------------------------------------- > > (Updated May 9, 2017, 6:11 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-7418 > https://issues.apache.org/jira/browse/MESOS-7418 > > > Repository: mesos > > > Description > ------- > > Added volume secret isolator. > > > Diffs > ----- > > src/CMakeLists.txt 40d921ee7026f5ac47efbf0243e1cafab57825f9 > src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a > src/slave/containerizer/mesos/containerizer.cpp 58ab74571fb14c6dbb1907151dc421f93e324bb5 > src/slave/containerizer/mesos/isolators/volume/secret.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/secret.cpp PRE-CREATION > src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328 > src/tests/containerizer/rootfs.cpp fdfecc65a3fcd19d6a4dfa574320f4d1f2755322 > src/tests/containerizer/volume_secret_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/59001/diff/6/ > > > Testing > ------- > > Added new tests an ran `make check`. > > > Thanks, > > Kapil Arya > > --===============3121121160766152685==--