From reviews-return-60405-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed May 10 21:09:45 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CF00B1970F for ; Wed, 10 May 2017 21:09:45 +0000 (UTC) Received: (qmail 9128 invoked by uid 500); 10 May 2017 21:09:45 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 9094 invoked by uid 500); 10 May 2017 21:09:45 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 9081 invoked by uid 99); 10 May 2017 21:09:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 May 2017 21:09:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 0D14BC322C; Wed, 10 May 2017 21:09:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id xBzDODgFwGYb; Wed, 10 May 2017 21:09:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3AB555F567; Wed, 10 May 2017 21:09:43 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 878C7E0069; Wed, 10 May 2017 21:09:42 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 83EEBC40297; Wed, 10 May 2017 21:09:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3914381553912284617==" MIME-Version: 1.0 Subject: Re: Review Request 59156: CMake: Use `list(APPEND x ...)` over `set(x ${x} ...)`. From: Jeff Coffler To: Li Li , John Kordich , Joseph Wu , Jeff Coffler Cc: mesos Date: Wed, 10 May 2017 21:09:42 -0000 Message-ID: <20170510210942.14550.68691@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jeff Coffler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59156/ X-Sender: Jeff Coffler X-ReviewBoard-ShipIt: 1 References: <20170510203405.14550.1111@reviews-vm2.apache.org> In-Reply-To: <20170510203405.14550.1111@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Jeff Coffler X-ReviewRequest-Repository: mesos --===============3914381553912284617== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59156/#review174556 ----------------------------------------------------------- Ship it! Ship It! - Jeff Coffler On May 10, 2017, 8:34 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59156/ > ----------------------------------------------------------- > > (Updated May 10, 2017, 8:34 p.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. > > > Bugs: MESOS-7497 > https://issues.apache.org/jira/browse/MESOS-7497 > > > Repository: mesos > > > Description > ------- > > This removes a CMake anti-pattern where `set` was used to append to a > variable, instead of the more explicit `list(APPEND)` or > `string(APPEND)` alternatives. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake 7b2669f0c54abf9b5e0fd60f8af01e97e1f0f86a > > > Diff: https://reviews.apache.org/r/59156/diff/1/ > > > Testing > ------- > > Re-configured and built on Windows. > > NOTE: This syntax should be preferred going forward. There are more instances of the anti-pattern the setting of source files, but we'll take care of it in a later patch to avoid too much churn. > > > Thanks, > > Andrew Schwartzmeyer > > --===============3914381553912284617==--