From reviews-return-60122-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat May 6 00:53:44 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1E00D18011 for ; Sat, 6 May 2017 00:53:44 +0000 (UTC) Received: (qmail 24095 invoked by uid 500); 6 May 2017 00:53:44 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 24060 invoked by uid 500); 6 May 2017 00:53:44 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 24049 invoked by uid 99); 6 May 2017 00:53:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 May 2017 00:53:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3831DC002B; Sat, 6 May 2017 00:53:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id pK7weRBGPVUP; Sat, 6 May 2017 00:53:41 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3D3ED5F566; Sat, 6 May 2017 00:53:40 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 84214E002C; Sat, 6 May 2017 00:53:39 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 65B89C40057; Sat, 6 May 2017 00:53:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0936857325520559632==" MIME-Version: 1.0 Subject: Re: Review Request 59001: Added volume secret isolator. From: Kapil Arya To: Jie Yu , Vinod Kone , Gilbert Song Cc: Chun-Hung Hsiao , mesos Date: Sat, 06 May 2017 00:53:39 -0000 Message-ID: <20170506005339.44875.71947@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Kapil Arya X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59001/ X-Sender: Kapil Arya References: <20170505104417.33377.94581@reviews-vm2.apache.org> In-Reply-To: <20170505104417.33377.94581@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/tests/containerizer/volume_secret_isolator_tests.cpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/secret.cpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/volume/secret.hpp Reply-To: Kapil Arya X-ReviewRequest-Repository: mesos --===============0936857325520559632== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59001/ ----------------------------------------------------------- (Updated May 5, 2017, 8:53 p.m.) Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Changes ------- Addressed Chun-Hung's comments. Bugs: MESOS-7418 https://issues.apache.org/jira/browse/MESOS-7418 Repository: mesos Description (updated) ------- Added volume secret isolator. Diffs (updated) ----- src/CMakeLists.txt 89cbd3f5a93f4891e8272d3b1136059ab1069d01 src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae src/slave/containerizer/mesos/isolators/volume/secret.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/volume/secret.cpp PRE-CREATION src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328 src/tests/containerizer/rootfs.cpp fdfecc65a3fcd19d6a4dfa574320f4d1f2755322 src/tests/containerizer/volume_secret_isolator_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/59001/diff/3/ Changes: https://reviews.apache.org/r/59001/diff/2-3/ Testing ------- Added new tests an ran `make check`. Thanks, Kapil Arya --===============0936857325520559632==--