From reviews-return-60080-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri May 5 10:43:37 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1009218899 for ; Fri, 5 May 2017 10:43:37 +0000 (UTC) Received: (qmail 80343 invoked by uid 500); 5 May 2017 10:43:37 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 80312 invoked by uid 500); 5 May 2017 10:43:37 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 80300 invoked by uid 99); 5 May 2017 10:43:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 May 2017 10:43:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 42DBBC0587; Fri, 5 May 2017 10:43:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id QSiRk-TC-_CL; Fri, 5 May 2017 10:43:33 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id F27305F523; Fri, 5 May 2017 10:43:32 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 43AA1E002C; Fri, 5 May 2017 10:43:32 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 35971C401CB; Fri, 5 May 2017 10:43:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8507181614042195326==" MIME-Version: 1.0 Subject: Re: Review Request 59000: Added environment secret isolator. From: Kapil Arya To: Jie Yu , Vinod Kone , Gilbert Song , Greg Mann Cc: mesos Date: Fri, 05 May 2017 10:43:32 -0000 Message-ID: <20170505104332.42721.96352@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Kapil Arya X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59000/ X-Sender: Kapil Arya References: <20170504223237.33378.83619@reviews-vm2.apache.org> In-Reply-To: <20170504223237.33378.83619@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/environment_secret.cpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/environment_secret.hpp X-ReviewBoard-Diff-For: src/tests/containerizer/environment_secret_isolator_tests.cpp Reply-To: Kapil Arya X-ReviewRequest-Repository: mesos --===============8507181614042195326== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On May 4, 2017, 6:32 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/environment_secret.cpp > > Lines 37-44 (patched) > > > > > > Why you need this? Can you make sure to avoid such small nits while copying pasting code? Please remove all unncessary headers, and do a sweep for other reviews as well! Sorry for the noise - that was really stupid copy-paste. Fixed now. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59000/#review173970 ----------------------------------------------------------- On May 5, 2017, 6:43 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59000/ > ----------------------------------------------------------- > > (Updated May 5, 2017, 6:43 a.m.) > > > Review request for mesos, Gilbert Song, Greg Mann, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added environment secret isolator. > > > Diffs > ----- > > src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 > src/launcher/executor.cpp b05f73e539c22d4d40f07df76168a06373b818d4 > src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae > src/slave/containerizer/mesos/isolators/environment_secret.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/environment_secret.cpp PRE-CREATION > src/tests/containerizer/environment_secret_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/59000/diff/2/ > > > Testing > ------- > > Added a new test and ran `make check`. > > > Thanks, > > Kapil Arya > > --===============8507181614042195326==--