| Joseph Wu |
Review Request 58908: Updated test mocks per interface changes. |
Tue, 02 May, 02:16 |
| Joseph Wu |
Review Request 58909: Added test helpers to tranlate to ContainerConfig. |
Tue, 02 May, 02:17 |
| Joseph Wu |
Review Request 58910: [WIP] Updated all tests that use Containerizer::launch(...). |
Tue, 02 May, 02:17 |
| Joseph Wu |
Re: Review Request 58900: Changed the default fetcher cache directory. |
Mon, 08 May, 22:20 |
| Joseph Wu |
Re: Review Request 58900: Changed the default fetcher cache directory. |
Mon, 08 May, 22:35 |
| Joseph Wu |
Re: Review Request 58908: Updated test mocks per interface changes. |
Mon, 08 May, 22:45 |
| Joseph Wu |
Review Request 59073: Updated Docker containerizer tests to use the old naming scheme. |
Mon, 08 May, 23:22 |
| Joseph Wu |
Re: Review Request 58910: Addressed a TODO about checkpointing in tests. |
Mon, 08 May, 23:22 |
| Joseph Wu |
Review Request 59074: Updated all tests that use Containerizer::launch(...). |
Mon, 08 May, 23:22 |
| Joseph Wu |
Re: Review Request 58907: Refactored Docker containerizer launch path per interface changes. |
Wed, 10 May, 18:33 |
| Joseph Wu |
Re: Review Request 58900: Changed the default fetcher cache directory. |
Wed, 10 May, 20:24 |
| Joseph Wu |
Re: Review Request 58900: Changed the default fetcher cache directory. |
Wed, 10 May, 20:32 |
| Joseph Wu |
Re: Review Request 59073: Updated Docker containerizer tests to use the old naming scheme. |
Wed, 10 May, 20:32 |
| Joseph Wu |
Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows. |
Wed, 10 May, 20:37 |
| Joseph Wu |
Re: Review Request 58910: Addressed a TODO about checkpointing in tests. |
Thu, 11 May, 00:26 |
| Joseph Wu |
Re: Review Request 59073: Updated Docker containerizer tests to use the old naming scheme. |
Thu, 11 May, 00:26 |
| Joseph Wu |
Review Request 59164: Updated fetcher tests to reflect changed interfaces. |
Thu, 11 May, 00:27 |
| Joseph Wu |
Re: Review Request 59074: Updated all tests that use Containerizer::launch(...). |
Thu, 11 May, 00:27 |
| Joseph Wu |
Re: Review Request 59155: CMake: Enable `/debug:fastlink` on Windows. |
Mon, 15 May, 17:16 |
| Joseph Wu |
Re: Review Request 59156: CMake: Use `list(APPEND x ...)` over `set(x ${x} ...)`. |
Mon, 15 May, 17:16 |
| Joseph Wu |
Re: Review Request 59157: Windows: Fixed toolset handling. |
Mon, 15 May, 17:17 |
| Joseph Wu |
Re: Review Request 59116: Windows: Updated `support/windows-build.bat`. |
Mon, 15 May, 17:26 |
| Joseph Wu |
Re: Review Request 58673: Fix FlagsFileTest to check for absolute path properly on Windows. |
Mon, 15 May, 17:32 |
| Joseph Wu |
Re: Review Request 58889: Remove FlagsFileTest.JSONFile from Windows. |
Mon, 15 May, 17:32 |
| Joseph Wu |
Re: Review Request 58906: Removed extranous sandbox initialization in Docker containerizer. |
Tue, 16 May, 01:03 |
| Joseph Wu |
Re: Review Request 59293: Windows: Fixed apply-reviews.py to retain line feeds. |
Thu, 18 May, 19:57 |
| Joseph Wu |
Re: Review Request 58900: Changed the default fetcher cache directory. |
Fri, 19 May, 22:05 |
| Joseph Wu |
Re: Review Request 58900: Changed the default fetcher cache directory. |
Fri, 19 May, 22:06 |
| Joseph Wu |
Review Request 59419: Updated mesos-local work directory structure. |
Fri, 19 May, 22:07 |
| Joseph Wu |
Re: Review Request 58899: Combined containerizer interface's launch methods. |
Fri, 19 May, 22:08 |
| Joseph Wu |
Review Request 59420: Added some comments to ContainerConfig protobuf. |
Fri, 19 May, 22:09 |
| Joseph Wu |
Re: Review Request 58903: Combined Mesos containerizer's launch methods. |
Fri, 19 May, 22:11 |
| Joseph Wu |
Re: Review Request 58904: Combined launch paths in ComposingContainerizer. |
Fri, 19 May, 22:12 |
| Joseph Wu |
Re: Review Request 58905: Changed naming of Docker containers to the pre-0.23 scheme. |
Fri, 19 May, 22:14 |
| Joseph Wu |
Re: Review Request 58907: Refactored Docker containerizer launch path per interface changes. |
Fri, 19 May, 22:15 |
| Joseph Wu |
Re: Review Request 59464: Add Fetcher total and success metrics. |
Tue, 23 May, 01:04 |
| Joseph Wu |
Re: Review Request 58905: Changed naming of Docker containers to the pre-0.23 scheme. |
Wed, 24 May, 10:34 |
| Joseph Wu |
Re: Review Request 59074: Updated all tests that use Containerizer::launch(...). |
Wed, 24 May, 10:34 |
| Joseph Wu |
Re: Review Request 59557: Windows: Bumped required CMake version to 3.8.1. |
Thu, 25 May, 20:28 |
| Joseph Wu |
Re: Review Request 59556: Windows: Updated build documentation. |
Thu, 25 May, 21:20 |
| Joseph Wu |
Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads. |
Thu, 25 May, 21:23 |
| Joseph Wu |
Re: Review Request 59500: Added Windows ReviewBot launch script. |
Thu, 25 May, 21:35 |
| Joseph Wu |
Re: Review Request 59353: Enabled DOCKER and ROOT filter flags on Windows. |
Fri, 26 May, 01:23 |
| Joseph Wu |
Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads. |
Fri, 26 May, 23:29 |
| Joseph Wu |
Re: Review Request 59691: Renamed `flags` to `libprocess_flags` to fix build. |
Wed, 31 May, 22:40 |
| Kapil Arya |
Re: Review Request 58924: Updated containerizer for isolator task_environment merge. |
Wed, 03 May, 22:23 |
| Kapil Arya |
Re: Review Request 58923: Added new ContainerLaunchInfo task_environment. |
Wed, 03 May, 22:23 |
| Kapil Arya |
Re: Review Request 58925: Updated runtime isolators to use new task_environment member. |
Thu, 04 May, 00:08 |
| Kapil Arya |
Re: Review Request 58759: Introduced SecretFetcher module interface. |
Thu, 04 May, 20:06 |
| Kapil Arya |
Re: Review Request 58760: Added default secret fetcher module. |
Thu, 04 May, 20:06 |
| Kapil Arya |
Review Request 58999: Added --secret_fetcher flag for agent. |
Thu, 04 May, 20:07 |
| Kapil Arya |
Review Request 59000: Added environment secret isolator. |
Thu, 04 May, 20:08 |
| Kapil Arya |
Review Request 59001: Added volume secret isolator. |
Thu, 04 May, 20:12 |
| Kapil Arya |
Re: Review Request 58999: Added --secret_fetcher flag for agent. |
Thu, 04 May, 23:08 |
| Kapil Arya |
Re: Review Request 58759: Introduced SecretFetcher module interface. |
Thu, 04 May, 23:29 |
| Kapil Arya |
Re: Review Request 58999: Added --secret_fetcher flag for agent. |
Thu, 04 May, 23:45 |
| Kapil Arya |
Re: Review Request 58759: Introduced SecretFetcher module interface. |
Thu, 04 May, 23:56 |
| Kapil Arya |
Re: Review Request 58999: Added --secret_fetcher flag for agent. |
Fri, 05 May, 07:39 |
| Kapil Arya |
Re: Review Request 58759: Introduced SecretResolver module interface. |
Fri, 05 May, 10:37 |
| Kapil Arya |
Re: Review Request 58760: Added default secret resolver module. |
Fri, 05 May, 10:38 |
| Kapil Arya |
Re: Review Request 58999: Added --secret_resolver flag to agent. |
Fri, 05 May, 10:41 |
| Kapil Arya |
Re: Review Request 59000: Added environment secret isolator. |
Fri, 05 May, 10:43 |
| Kapil Arya |
Re: Review Request 59000: Added environment secret isolator. |
Fri, 05 May, 10:43 |
| Kapil Arya |
Re: Review Request 59001: Added volume secret isolator. |
Fri, 05 May, 10:44 |
| Kapil Arya |
Re: Review Request 58999: Added --secret_resolver flag to agent. |
Fri, 05 May, 16:13 |
| Kapil Arya |
Re: Review Request 58759: Introduced SecretResolver module interface. |
Sat, 06 May, 00:31 |
| Kapil Arya |
Re: Review Request 58760: Added default secret resolver module. |
Sat, 06 May, 00:32 |
| Kapil Arya |
Re: Review Request 58999: Added --secret_resolver flag to agent. |
Sat, 06 May, 00:33 |
| Kapil Arya |
Re: Review Request 59000: Added environment secret isolator. |
Sat, 06 May, 00:33 |
| Kapil Arya |
Re: Review Request 59001: Added volume secret isolator. |
Sat, 06 May, 00:53 |
| Kapil Arya |
Re: Review Request 59001: Added volume secret isolator. |
Sat, 06 May, 00:57 |
| Kapil Arya |
Re: Review Request 58999: Added --secret_resolver flag to agent. |
Sat, 06 May, 01:26 |
| Kapil Arya |
Re: Review Request 59001: Added volume secret isolator. |
Sat, 06 May, 21:29 |
| Kapil Arya |
Re: Review Request 58759: Introduced SecretResolver module interface. |
Mon, 08 May, 22:19 |
| Kapil Arya |
Re: Review Request 58760: Added default secret resolver module. |
Mon, 08 May, 22:19 |
| Kapil Arya |
Re: Review Request 58999: Added --secret_resolver flag to agent. |
Mon, 08 May, 22:19 |
| Kapil Arya |
Re: Review Request 59000: Added environment secret isolator. |
Mon, 08 May, 22:19 |
| Kapil Arya |
Re: Review Request 59001: Added volume secret isolator. |
Mon, 08 May, 22:20 |
| Kapil Arya |
Re: Review Request 58759: Introduced SecretResolver module interface. |
Tue, 09 May, 18:10 |
| Kapil Arya |
Re: Review Request 58760: Added default secret resolver module. |
Tue, 09 May, 18:11 |
| Kapil Arya |
Re: Review Request 59000: Added environment secret isolator. |
Tue, 09 May, 18:11 |
| Kapil Arya |
Re: Review Request 58999: Added --secret_resolver flag to agent. |
Tue, 09 May, 18:11 |
| Kapil Arya |
Re: Review Request 59001: Added volume secret isolator. |
Tue, 09 May, 18:11 |
| Kapil Arya |
Re: Review Request 58999: Added --secret_resolver flag to agent. |
Tue, 09 May, 18:12 |
| Kapil Arya |
Re: Review Request 59000: Added environment secret isolator. |
Tue, 09 May, 18:13 |
| Kapil Arya |
Re: Review Request 59001: Added volume secret isolator. |
Fri, 12 May, 02:20 |
| Kapil Arya |
Re: Review Request 58759: Introduced SecretResolver module interface. |
Fri, 12 May, 17:52 |
| Kapil Arya |
Re: Review Request 58760: Added default secret resolver module. |
Fri, 12 May, 17:52 |
| Kapil Arya |
Re: Review Request 58999: Added --secret_resolver flag to agent. |
Fri, 12 May, 17:52 |
| Kapil Arya |
Re: Review Request 59000: Added environment secret isolator. |
Fri, 12 May, 17:52 |
| Kapil Arya |
Re: Review Request 59001: Added volume secret isolator. |
Fri, 12 May, 17:53 |
| Kapil Arya |
Re: Review Request 58759: Introduced SecretResolver module interface. |
Tue, 16 May, 19:22 |
| Kapil Arya |
Re: Review Request 58760: Added default secret resolver module. |
Tue, 16 May, 19:22 |
| Kapil Arya |
Re: Review Request 58999: Added --secret_resolver flag to agent. |
Tue, 16 May, 19:22 |
| Kapil Arya |
Re: Review Request 59000: Added environment secret isolator. |
Tue, 16 May, 19:22 |
| Kapil Arya |
Re: Review Request 59001: Added volume secret isolator. |
Tue, 16 May, 19:22 |
| Kapil Arya |
Re: Review Request 58999: Added --secret_resolver flag to agent. |
Tue, 16 May, 19:24 |
| Kapil Arya |
Re: Review Request 59000: Added environment secret isolator. |
Tue, 16 May, 19:25 |
| Kapil Arya |
Review Request 59318: Replace in EXPECT with an ASSERT in master_tests to avoid segfaults. |
Tue, 16 May, 19:28 |
| Kapil Arya |
Review Request 59372: Disable port-mapping isolator by default. |
Thu, 18 May, 17:40 |