mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 59691: Renamed `flags` to `libprocess_flags` to fix build.
Date Wed, 31 May 2017 22:40:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59691/#review176541
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On May 31, 2017, 1:34 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59691/
> -----------------------------------------------------------
> 
> (Updated May 31, 2017, 1:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-7597
>     https://issues.apache.org/jira/browse/MESOS-7597
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> On Windows, the use of pre-compiled headers causes problems when reusing
> the identifier `flags`. This commit renames it to `libprocess_flags` to
> avoid conflicts.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 4e60231802325afe7f9c0f30dc9efa431501a617 
> 
> 
> Diff: https://reviews.apache.org/r/59691/diff/1/
> 
> 
> Testing
> -------
> 
> Built and ran `stout-tests` and `libprocess-tests` on Windows. Also ran `make check`
in `build/3rdparty` on Linux. This resolves the build break.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message